Comments (9)
rabimba
commented on July 20, 2024
Added. Though not sure this is what was expected?
from android-custom-camera-with-live-filter.
PulsarBlow
commented on July 20, 2024
Working on it
from android-custom-camera-with-live-filter.
arshadkazmi42
commented on July 20, 2024
@rabimba Looks good. just need a small change and its ready to be merged
from android-custom-camera-with-live-filter.
arshadkazmi42
commented on July 20, 2024
Working on it
@rabimba Is already working on it before you. So its @rabimba issue, you can explore our other issues for more bugs
from android-custom-camera-with-live-filter.
PulsarBlow
commented on July 20, 2024
I thought you had to follow this ;)
Anyone who is not following above two steps, their PR will be rejected
from android-custom-camera-with-live-filter.
arshadkazmi42
commented on July 20, 2024
@PulsarBlow valid point. @rabimba you did not followed the steps correctly. So we will be taking @PulsarBlow PR.
@PulsarBlow you have created the PR in your forked repo, you should it create it in this repo
from android-custom-camera-with-live-filter.
PulsarBlow
commented on July 20, 2024
@arshadkazmi42 Sorry for that, PR should be good now.
from android-custom-camera-with-live-filter.
rabimba
commented on July 20, 2024
I thought the two steps needed was
- Put a comment here
- tag this issue in PR
I think I did both first. But whatever. Your decision @arshadkazmi42
from android-custom-camera-with-live-filter.
arshadkazmi42
commented on July 20, 2024
@rabimba You should have added a comment here first, that you are working on it. You can find more issues in the repo to work on.
from android-custom-camera-with-live-filter.
Related Issues (15)
- Add video recording feature HOT 4
- Update README HOT 2
- Imporve UI HOT 4
- Add .gitignore file HOT 1
- Remove note from readme HOT 2
- Add contributors avatar in README HOT 4
- Improve README.md file HOT 3
- Add app snapshot in README.md
- Clear ignored files from respository
- Change contributors hof
- Filters not working HOT 1
- Create a logo for app
- Add CODE_OF_CONDUCT HOT 2
- Add LICENSE HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from android-custom-camera-with-live-filter.