Comments (4)
+ <Compile Include="Markdown.Anchor.cs" />
+ <Compile Include="Markdown.Block.cs" />
+ <Compile Include="Markdown.Config.cs" />
+ <Compile Include="Markdown.Email.cs" />
+ <Compile Include="Markdown.Image.cs" />
+ <Compile Include="Markdown.Inline.cs" />
+ <Compile Include="Markdown.Tab.cs" />
+ <Compile Include="Markdown.Code.cs" />
+ <Compile Include="Markdown.Header.cs" />
+ <Compile Include="Markdown.Link.cs" />
+ <Compile Include="Markdown.List.cs" />
+ <Compile Include="Markdown.Quote.cs" />
This is a completely untenable patch for me -- every time I update Stack
Overflow, I
now need to paste in 12-13 files instead of one?
I just don't agree that there's any benefit in breaking it apart, because...
a) the current markdown.cs is, IMHO, not too long; I have no trouble working on
it
b) everything in markdown.cs relates to Markdown and thematically belongs
together
c) there's no benefit other than "I just like shorter files" to doing this --
no bugs
are fixed, no new features are added. It could also be argued this is a
negative:
instead of a simple single file, there are now 12 files to keep track of, which
probably have to go in their own folder, which has to be kept track of, etc etc
etc.
I think you might look at forking the project if you want to rearchitect it so
radically.
Original comment by [email protected]
on 7 Jan 2010 at 9:25
from markdownsharp.
When you update Stack Overflow, how do you do it? Perhaps the workflow in
updating
Stack Overflow can be improved or changed, allowing this refactoring to go
through
without adding any overhead to updating SO?
a) It's a matter of taste, of course, but I find that any file that surpass
somewhere around 500 lines to be too long.
b) Yes, this is why it's in one project. Keeping everything in one file beause
it
"thematically belongs together" is imho a stretch, though. It would be no
problem to
encapsulate all logic even further than what I have by creating separate
classes for
separate concerns (there are almost no cross-file method calls involved), but I
think partial classes solves the issue well enough.
c) Having shorter code files fixes no bugs, true. The "feature" this
refactoring
adds, though, is to make it a lot easier to dig into the correct file when you
want
to fix e.g. the anchor logic, plus it makes the project easier to understand
for
newcomers.
I'm not interested in forking; duplication of effort is usually a bad idea. I
hope
instead that we can find some kind of compromise that solves this issue without
making it harder for you to work on the project. :)
Original comment by asbjornu
on 7 Jan 2010 at 9:38
from markdownsharp.
I appreciate the input, but we will have to agree to disagree.
I sure would prefer some help on our failing unit test, than this discussion on
the
color of our bikeshed.. :)
Original comment by [email protected]
on 7 Jan 2010 at 9:40
- Changed state: WontFix
from markdownsharp.
That's okay. You're the king of this castle. :)
Original comment by asbjornu
on 7 Jan 2010 at 1:56
from markdownsharp.
Related Issues (20)
- Problems on img HOT 1
- Additional unit tests
- title element not escaped
- Problem with auto email links
- Add link to Pagedown on the project home page. HOT 1
- Allow to set base url for relative url
- URL detection bug for URLs that contain parentheses
- f3973492a27c breaks ConfigTest.TestEncodeProblemUrlCharacters
- Enable EmailEncoding as an option HOT 1
- <code> tags are rendered inside of <pre> for code blocks
- Add option to avoid Paragraph around single element
- Support Pandoc Extensions to Markdown
- Add Strikethrough
- Have the option to add a prettify class name to the <pre> tags
- URL: Support protcol-relative URLs
- Auto-URLs are breaking with any url that has an underscore HOT 1
- Strange <p> tag placement
- Unit test error: MarkdownSharpTests.ConfigTest.TestEncodeProblemUrlCharacters HOT 1
- AutoNewlines set through MarkdownOptions replaces EOL with <br instead of <br />
- Add SkipCodeBlocks Option HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from markdownsharp.