Git Product home page Git Product logo

Comments (6)

arquicanedo avatar arquicanedo commented on June 17, 2024

I took a first pass at the shutdown() method.

These two lines have been there for a while. I don't know where I got this from but I could not find any documentation about the SimpleCallbackEvent.

	public var timerChanged = new SimpleCallbackEvent("timerChanged");
	public var flipChanged = new SimpleCallbackEvent("flipChanged");

The shutdown method sets them to null.

from barbecueboss.

arquicanedo avatar arquicanedo commented on June 17, 2024

Less vibration probably helps battery optimization so I like your new duration. It feels much more natural than the long one. I also changed the settings to the flipVibrator. In practice, I dont care so much having two types of vibrators to indicate start or a flip.

from barbecueboss.

nilsbenson avatar nilsbenson commented on June 17, 2024

Going to leave this case open until we have a chance to look at the ability to disable activity and GPS tracking. Those are probably the top 2 users of the battery now that we've cleaned up the timer drawing.

from barbecueboss.

arquicanedo avatar arquicanedo commented on June 17, 2024

We need to test in the watches to make sure it works. The #46 is related to this.

from barbecueboss.

nilsbenson avatar nilsbenson commented on June 17, 2024

Looks good overall. I do think we need to make sure that if the user turns off the activity recording, that we stop and discard any activity that was already running. Otherwise, the user has to restart the app to pick up the new setting.

from barbecueboss.

nilsbenson avatar nilsbenson commented on June 17, 2024

tested pretty heavily the last couple days, looks good, closing.

from barbecueboss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.