Support flycheck.el about drupal-mode HOT 9 CLOSED

A minor mode does not require any special “support” for Flycheck. If there is a special checker for Drupal code, open an issue in the Flycheck tracker, name the tool, show some example output, and I'll add it to Flycheck itself, so that Flycheck automatically works–given that the user enabled it.

from drupal-mode.

Actually what I had in mind was getting the code in flycheck/flycheck#71 into good shape - including adding the phpcs standard to be used as a flycheck-def-config-file-var.

In my drupal-mode (which is - among other things - a minor mode for php-modeI) I would then set the "Drupal" standard as buffer local variable.

from drupal-mode.

flycheck-def-config-file-var is not the right tool for this, as configuration files receive special handling that breaks with simple string values.

See flycheck/flycheck#72 for what is required to support coding standards. You'll have to wait until that issue is fixed.

from drupal-mode.

Good point. Guess I haven't studied flycheck enought yet 😃

Glad to see you plan to support this.

from drupal-mode.

@arnested Flycheck now supports coding standards for PHP CodeSniffer. If you can tell me, how to install the Drupal Standard, and how to detect in code whether the standard is installed, I can even try to enable Drupal rules automatically if drupal-mode is active.

from drupal-mode.

@lunaryorn @arnested I'll write up some documentation on how to install the Drupal Standard and how to test it in the next few days, unless Arne beats me to it. Glad to hear this is working.

from drupal-mode.

I merged @xendk's pull request (and may a few minor changes).

I'm closing this issue now but @lunaryorn and @dhaley (and everyone else) are welcome to reopen or add new issues if you still miss stuff. I'm still not using flychk myself (probably should - @xendk has been trying to convince me several times at the office 😄).

from drupal-mode.

@arnested I commented on #35. I generally like the pull request, but how it enables the special Drupal syntax checker needs to be improved.

from drupal-mode.

Thank you for the comments, @lunaryorn.

@xendk is already looking into your comments I can see. Otherwise I'll nag him Friday when I see him at the office.

from drupal-mode.