Git Product home page Git Product logo

Comments (8)

glasser avatar glasser commented on July 23, 2024 1

I got a simpler CL into Go: golang/go@b58515b

So this should work without a workaround in 1.6.

Issue in go repo: golang/go#12943

from go-proxyproto.

armon avatar armon commented on July 23, 2024

Hmm that is nasty. Not sure I see an obvious solution to this, it looks like it will always require ugly hacks.

from go-proxyproto.

glasser avatar glasser commented on July 23, 2024

Here's a CL for Go that should fix this. https://go-review.googlesource.com/#/c/15832/

from go-proxyproto.

glasser avatar glasser commented on July 23, 2024

and a workaround we're using: https://gist.github.com/glasser/ac531523a027cbe3955d

from go-proxyproto.

armon avatar armon commented on July 23, 2024

@glasser Thanks for the heads up!

from go-proxyproto.

owenthereal avatar owenthereal commented on July 23, 2024

@glasser I'm curious what you ended up doing with this issue? I will need to handle proxy protocol in Go too...

from go-proxyproto.

glasser avatar glasser commented on July 23, 2024

As described above, this should be fixed in Go 1.6. My gist above is an annoying workaround for 1.5.

from go-proxyproto.

owenthereal avatar owenthereal commented on July 23, 2024

Cool thanks @glasser

from go-proxyproto.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.