struct2json Vulnerability Analysis An unsafe o

字符串的话，是否要修改成：sizeof是否要-1： <div class="snippet-clipboard-content n

An unsafe operation is found in the S2J_STRUCT_GET_string_ELEMENT function about struct2json HOT 5 CLOSED

armink commented on August 23, 2024 1

An unsafe operation is found in the S2J_STRUCT_GET_string_ELEMENT function

from struct2json.

Comments (5)

libradoge commented on August 23, 2024

字符串的话，是否要修改成：sizeof是否要-1：

#define S2J_STRUCT_GET_string_ELEMENT(to_struct, from_json, _element) \ 
  json_temp = cJSON_GetObjectItem(from_json, #_element); \ 
  if (json_temp) strncpy((to_struct)->_element, json_temp->valuestring,sizeof((to_struct)->_element) -1 );

from struct2json.

abergmann commented on August 23, 2024

CVE-2020-29203 was assigned to this issue.

from struct2json.

armink commented on August 23, 2024

Thanks for your feedback, can you submit a PR for it?

from struct2json.

libradoge commented on August 23, 2024

Thanks for your feedback, can you submit a PR for it?

It's my first time to submit a PR, so please check my work carefully...And thank you for giving me this chance!

from struct2json.

armink commented on August 23, 2024

Thanks for your feedback, can you submit a PR for it?

It's my first time to submit a PR, so please check my work carefully...And thank you for giving me this chance!

Good job.

Thank you for your contribution, PR has been merged

from struct2json.

Recommend Projects