Git Product home page Git Product logo

Comments (4)

jon-chuang avatar jon-chuang commented on August 17, 2024

This will unfortunately require a LOT of manual changes. It is a huge technical debt that unfortunately will require a lot of breaking changes.

from algebra.

jon-chuang avatar jon-chuang commented on August 17, 2024

The real solution ought to be to refactor out the BaseField to a Curve trait. I'm not sure how many breaking changes this would result in. Certainly, all the curve in algebra need to be updated. But it may be worth it. I think this is the easiest way not to break too many things and ensure that future generations do not have to keep disambiguate trait types endlessly

from algebra.

Pratyush avatar Pratyush commented on August 17, 2024

Do you have a code example that triggers this? That is, which traits face this issue? AffineCurve and ProjectiveCurve?

from algebra.

Pratyush avatar Pratyush commented on August 17, 2024

Closing this in favour of #41 , which should address your concerns.

from algebra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.