Git Product home page Git Product logo

Comments (5)

arkhipenko avatar arkhipenko commented on May 29, 2024

Please send source code. I suspect you don't destroy the actual dictionary object.
Where is delete new_cache?

from dictionary.

frezik avatar frezik commented on May 29, 2024

Source code is in dictionary_memleak.txt (github doesn't let you attach .ino files).

new_cache simply becomes cache after being loaded on each iteration through the rebuild.

from dictionary.

arkhipenko avatar arkhipenko commented on May 29, 2024
  1. As I suspected you never destroy the actual Dictionary object - you created a memory leak by creating a new Dictionary and never deleting the old one. This is a classic "dropping pointers" scenario. C++ is not a managed language, you have to manage your objects.
  2. 8192 objects maybe too much for esp32 heap without PSRAM - start with a few hundred and experiment.
void loop()
{
    times_rebuilt++;

    Serial.print( times_rebuilt );
    Serial.println( " attempt" );
    log_mem( "    Heap before rebuild: " );
   new_cache = NULL;
    Dictionary *new_cache = new Dictionary( dict_size );
// where is error handling?
   if ( new_cache  ) {
    log_mem( "    Heap after allocation: " );
    
    new_cache->jload( JSON );
    log_mem( "    Heap after JSON parse: " );

    // Fatal error on ESP32
    //cache->destroy();

    //cache = new_cache;  this does nothing in C++
   delete new_cache;
   }
   else {
     // there was a memory allocation error
   }
    log_mem( "    Heap after replacing cache: " );
}

By the way, the dictionary was never meant to operate with boolean values. It clearly states that the only supported type is String.

from dictionary.

arkhipenko avatar arkhipenko commented on May 29, 2024

Also, did you check the return value of new_cache->jload( JSON );? It must have returned an error.

from dictionary.

arkhipenko avatar arkhipenko commented on May 29, 2024

cache->destroy();
cache is undefined (NULL) on the first iteration, that caused the panic

from dictionary.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.