Git Product home page Git Product logo

Comments (7)

arielsalminen avatar arielsalminen commented on July 18, 2024

Can you provide a link to the page where the problem is? Can't really reproduce this bug now…

from responsiveslides.js.

gausarts avatar gausarts commented on July 18, 2024

Thanks for the offer, but unfortunately it's just local test, no public access.

Allow me to clarify:

  1. This doesn't happen if I provide "controls" selector to move
    controls either back to default after UL, or anywhere, as long as
    controls selector provided. But if I don't provide controls, the dup
    pagers happen.
  2. Your plugin do not create dup pagers if embedded inside colorbox.
    Only when outside colorbox, but at the same page where colorbox are,
    and only after colorbox launched, then dup pagers happen.

Relevant codes:

$(".responsive-slides ul").once('responsive-slides').responsiveSlides({
speed: 1200,
pager: true,
nav: true,
pause: true,
pauseControls : true,
controls: '.rslides-content'
});

Note: .once('responsive-slides') is Drupal code to avoid dups after ajax call.

FYI, this doesn't happen with flexslider, but your lightweight plugin
is preferred.

Thanks

On 6/19/12, Viljami Salminen
[email protected]
wrote:

Can you provide a link to the page where the problem is? Can't really
reproduce this bug now…


Reply to this email directly or view it on GitHub:
#53 (comment)

gausarts.com

from responsiveslides.js.

arielsalminen avatar arielsalminen commented on July 18, 2024

Wait a sec, I'll do some more testing to see if I can reproduce this issue :-)

from responsiveslides.js.

arielsalminen avatar arielsalminen commented on July 18, 2024

Are you using this "colorbox" https://github.com/jackmoore/colorbox ?

from responsiveslides.js.

arielsalminen avatar arielsalminen commented on July 18, 2024

Hmm, no, still can't reproduce this issue. Tested using the newest version of https://github.com/jackmoore/colorbox and ResponsiveSlides and everything worked like it should.

I'm afraid that I can't help here without seeing the original page and/or source html, css and js. :-(

from responsiveslides.js.

gausarts avatar gausarts commented on July 18, 2024

Ok, thanks. I will you know whenever available for preview.

On 6/19/12, Viljami Salminen
[email protected]
wrote:

Hmm, no, still can't reproduce this issue. Tested using the newest version
of https://github.com/jackmoore/colorbox and ResponsiveSlides and everything
worked like it should.

I'm afraid that I can't help here without seeing the original page and/or
source html, css and js. :-(


Reply to this email directly or view it on GitHub:
#53 (comment)

gausarts.com

from responsiveslides.js.

gausarts avatar gausarts commented on July 18, 2024

I think I found the issue. Its the selector I used

$(".responsive-slides ul")

Notice that anonymous UL.

When I add a class to UL - $(".responsive-slides ul.slideshows"), then
no dups happened.

Sorry if I missed it in the first place.

But I think the issue sounds logical with the way rslides structured,
and I missed to provide the proper target selector:

<ul class="rslides rslides1" id="slider2">
  ....
</ul>
<ul class="rslides_tabs rslides1_tabs">
   ....
</ul>

You can close the issue. Again thanks for looking into this.

On 6/19/12, gaus surahman [email protected] wrote:

Ok, thanks. I will you know whenever available for preview.

On 6/19/12, Viljami Salminen
[email protected]
wrote:

Hmm, no, still can't reproduce this issue. Tested using the newest
version
of https://github.com/jackmoore/colorbox and ResponsiveSlides and
everything
worked like it should.

I'm afraid that I can't help here without seeing the original page and/or
source html, css and js. :-(


Reply to this email directly or view it on GitHub:
#53 (comment)

gausarts.com

gausarts.com

from responsiveslides.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.