Comments (2)
Looks like the unit tests start a webserver at a fixed address of 9000. There might be a problem if two unit tests run concurrently that use the same port.
Might want to try randomizing the port in signal_test.go
:
web := New()
signal := v1alpha1.Signal{
Webhook: &v1alpha1.WebhookSignal{
Port: common.WebhookServiceTargetPort, <<<<-------------------- HERE ----------
Endpoint: endpoint,
Method: httpMethod,
},
}
events, err := web.Start(&signal)
from argo-events.
Thanks for creating this issue, I was noticing the same patterns in some of the tests. I think the port may be the problem. Why would the tests would be running concurrently since the t.Parallel()
is not set for these tests?
Also do you think we need to randomize here, why not just increment the port for each test post
, put
, and delete
?
from argo-events.
Related Issues (20)
- GitHub App authentication for Git Trigger Source
- Using git as a source for k8s trigger: git executable not found HOT 4
- Sensor trigger execution order HOT 1
- Argo Events Kubernetes Admission Webhook Denial of Service HOT 1
- EventSource Azure Queue Storage unable to decode base64
- EventSensor DLQ after retry exhaustion HOT 1
- AMQP trigger support
- Updating a Workflow While It's Running Spawns Multiple Workflows HOT 1
- failed to get value by key: key body.message does not exist to in the event payload HOT 1
- Allow namespace-scoped permissions when doing a cluster-level install HOT 1
- Unable to delete a cluster scoped resource HOT 1
- Finish the field specifications in the EventBus CRD HOT 1
- Provide option to disable TLS in NATS
- Support AWS EventBridge
- Support NATS Jetstream Consumer as EventSource
- HTTP Trigger Support Multipart/form-data encoding
- Allow Configurable Retention and Discard Policies for Jetstream EventBus
- Sensor high memory consuming / Low event processing throughput
- Sensor does not support automountServiceAccountToken
- Nats Jetstream Support in EventSource HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from argo-events.