Git Product home page Git Product logo

Comments (2)

shrinandj avatar shrinandj commented on August 17, 2024

Looks like the unit tests start a webserver at a fixed address of 9000. There might be a problem if two unit tests run concurrently that use the same port.

Might want to try randomizing the port in signal_test.go:

	web := New()
	signal := v1alpha1.Signal{
		Webhook: &v1alpha1.WebhookSignal{
			Port:     common.WebhookServiceTargetPort,  <<<<--------------------  HERE ----------
			Endpoint: endpoint,
			Method:   httpMethod,
		},
	}
	events, err := web.Start(&signal)

from argo-events.

magaldima avatar magaldima commented on August 17, 2024

Thanks for creating this issue, I was noticing the same patterns in some of the tests. I think the port may be the problem. Why would the tests would be running concurrently since the t.Parallel() is not set for these tests?

Also do you think we need to randomize here, why not just increment the port for each test post, put, and delete?

from argo-events.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.