Comments (9)
2.11.1 updated the upstream redis-ha chart version. That change included a change in image repo. https://github.com/DandyDeveloper/charts/pull/214/files
I don't think that change should have been included in our change. I'll open a PR to revert to the old image.
from argo-cd.
Thank you Michael! That makes a lot of sense.
from argo-cd.
Line where change occurred. There are a few lines for HAProxy and Redis in this file that were all changed. You can search ecr.aws
to find the changes.
f1a449e#diff-f57b731949fe998635a3f1de62d2cd7c5ae7139f7b288af17ee7f7166f3f5b6a
Commit which made the change.
from argo-cd.
Also worth noting that the non-ha installs still use Docker Hub for HAProxy and Redis. This change only affects HA installers. Sort of a weird thing I noticed. Why use two registry sources?
from argo-cd.
@avo-sepp could you check #18329 and let me know if the language of the third paragraph makes sense?
from argo-cd.
Looks good. I would suggest using the word Policy for Cosign. Something like "make sure your Image Validation policy includes the AWS ECR as an approved registry"
from argo-cd.
Pushed with that additional language! lmk if you'd like me to add you as a co-author, I'd just need an email to include in the commit message. :-)
from argo-cd.
Sure! I can send you an email in Slack on the CNCF Slack. Do you usually use your Github hide-my-email address for these? That's what I use in commits.
from argo-cd.
Reverted the change for 2.11 and added a release note for 2.12.
from argo-cd.
Related Issues (20)
- seems no diff restfulapi?
- Argo UI for Rollout has no Promote button and action HOT 2
- Can use list values inside generator HOT 6
- UI Application Details Tree not showing the complete name of applications/resources HOT 6
- grpc: error while marshaling: proto: required field \"resourceName\" not set HOT 3
- argocd app sync --local has a 2mb HOT 1
- Argocd out of sync at part of spec.kustomize HOT 1
- [controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.
- Suspended Jobs Should Not Suspend Apps (Atleast Conditionally)
- Stdlib Critical vulnerability
- UI - Select arrow icon was hidden in create application page HOT 2
- UI - Dark mode is not working in full screen log page HOT 2
- ArgoCD didn't detect diff between desired and live manifests about Affinity Settings
- TLS certs not passed correctly if helm repo contains path in repository URL HOT 1
- UI - Health Summary icons and names are not aligned for Missing status in applications summary view HOT 1
- Add Native Functions for Rendering Helm/Kustomize in Jsonnet VM
- ApplicationSet PullRequest Generator Regex Mismatch error for webhook event
- rpc error: code = Unknown desc = error testing repository connectivity: repository "" cannot be initialized: repo URL is invalid
- argocd.argoproj.io/skip-reconcile requires argocd controller to be restarted HOT 1
- notifications controller not included in core install HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from argo-cd.