Comments (4)
I'm willing to take a swing at this, unless Jonathan is already working on it.
from applicationset.
FWIW It's not a perfect example of the problem: I originally reproduced it when reviewing #45, but I can't exactly include an unmerged PR in the reproduction steps of another issue 😄 .
As for why 0 and not 1 (or 3), here's the design doc paragraph on that:
Applications Naming
Application names are required to be templated by the user and should be unique. The reasoning behind this is that ApplicationSets cannot reliably formulate a stable name which would be generated consistently when the ApplicationSpec changes. For example, we could not use the same technique utilized by ReplicaSets (which formulates the ReplicaSet name based on the hash of the pod template), because ReplicaSets are intended to be ephemeral whereas Applications are not.
Name conflicts within the same ApplicationSet are considered an error condition on the ApplicationSet. Name conflicts with existing applications would be an error or warning. To resolve this, ApplicationSets might also provide the ability to adopt existing applications.
from applicationset.
Why 0 and not 1? The first application to be created is perfectly fine
from applicationset.
OK, so when an appliactionset generates an application object then it should check for duplications and report an error
@jgwest do you want to raise a PR?
from applicationset.
Related Issues (20)
- Webhooks: add support for Bitbucket HOT 3
- Github rate limit hit, even using `scmProvider.filters` HOT 1
- scmProvider Github filter combination (repositoryMatch + labelMatch) not generating apps HOT 1
- Merge generator where a generator can reference items of another one HOT 1
- FATA[0000] rpc error: code = Unimplemented desc = unknown service applicationset.ApplicationSetService HOT 2
- using helm and git repos inside ApplicationSet HOT 2
- git-generator-directory - doesn't apply value file
- docs: merge generator typo in example
- Feature Request: ApplicationSet Generators Should Support Jinja Conditionals HOT 1
- ApplicationSet not able to render helm chart when value is not defined in generator list
- Include SHA of test merge commit in PR generator for GitHub
- clusterDecisionResource example outdate ?
- Ability to provide multiple values files for Helm chart, using multiple sources HOT 3
- ApplicationSet fails silently
- Replace deprecated `set-output` command with environment file HOT 1
- How to set scmProvider filter based on repository group or path? HOT 1
- scmProvider for gitlab should export a Normalized version of the organization value HOT 2
- Plugin Generator throws `ApplicationSet: strict decoding error: unknown field "spec.generators[0].plugin"` HOT 4
- Application Set with Existing Project Issue HOT 1
- Matrix generator - Combine SCM and Git Generators, consume parameters from parent HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from applicationset.