Git Product home page Git Product logo

Comments (4)

jopit avatar jopit commented on July 30, 2024 2

I'm willing to take a swing at this, unless Jonathan is already working on it.

from applicationset.

jgwest avatar jgwest commented on July 30, 2024 1

FWIW It's not a perfect example of the problem: I originally reproduced it when reviewing #45, but I can't exactly include an unmerged PR in the reproduction steps of another issue 😄 .

As for why 0 and not 1 (or 3), here's the design doc paragraph on that:

Applications Naming

Application names are required to be templated by the user and should be unique. The reasoning behind this is that ApplicationSets cannot reliably formulate a stable name which would be generated consistently when the ApplicationSpec changes. For example, we could not use the same technique utilized by ReplicaSets (which formulates the ReplicaSet name based on the hash of the pod template), because ReplicaSets are intended to be ephemeral whereas Applications are not.

Name conflicts within the same ApplicationSet are considered an error condition on the ApplicationSet. Name conflicts with existing applications would be an error or warning. To resolve this, ApplicationSets might also provide the ability to adopt existing applications.

from applicationset.

OmerKahani avatar OmerKahani commented on July 30, 2024

Why 0 and not 1? The first application to be created is perfectly fine

from applicationset.

OmerKahani avatar OmerKahani commented on July 30, 2024

OK, so when an appliactionset generates an application object then it should check for duplications and report an error

@jgwest do you want to raise a PR?

from applicationset.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.