slices.Clip description about gotraining HOT 10 CLOSED

Ok. I'll look at this again. It seems I did make the wrong conclusion. After review I'll fix anything that needs to be fixed.

Thanks!!

from gotraining.

OMG! How did I miss that when I was reviewing this post :(

THANK YOU for finding this and creating an issue. Can you please send me an email. [email protected]. I would like to give you access to the Go Bundle.

I should have a fix in the next hour.

from gotraining.

Your code example is not using the slices API at all?

Your 3 index slice examples are a smell. I have never found a reason for the last two values not to be the same.

from gotraining.

Sorry, I may be wasn't clear enough.
Here is the code with slices API, basically expressing the same idea.

package main

import (
	"fmt"
	"slices"
)

func main() {
	var arr [10000]int
	fmt.Println("arr", &arr[0])
	fmt.Printf("Len(%d), Cap(%d)\n", len(arr), cap(arr))

	slArr := arr[:10]
	fmt.Println("slArr", &slArr[0])
	fmt.Printf("Len(%d), Cap(%d)\n", len(slArr), cap(slArr))

	slArr = slices.Clip(slArr)
	fmt.Println("slArr", &slArr[0])
	fmt.Printf("Len(%d), Cap(%d)\n", len(slArr), cap(slArr))
}

This code shows that the underlying array for slArr after slices.Clip doesn't change.
It's still the array taking O(10000) memory.

The Figure 3 of the post shows that after list = slices.Clip(list) new list slice points to the new underlying array with smaller size.

Figure 3 shows the slice value and underlying array after the clip operation.

So in case of the code above it would mean that slArr after slices.Clip points to a new array taking O(10) memory.

May be you meant smth else with Figure 3, but at least that's how I read it. And probably other readers of your post can read it in the same way. For me it looked like slices.Clip makes a new slice with new underlying array of (probably) smaller size and copies elements from the original slice. This probably can lead to a wrong opinion that slices.Clip can be used to save allocated memory of a process and free some memory to be garbage collected.

from gotraining.

I am happy to help :)

from gotraining.

@ardan-bkennedy

I've sent you an email, btw. May be you need to check your spam folder.

from gotraining.

I've been out for a few days but I don't see it. Can you send it again please.

from gotraining.

Done ✅

from gotraining.

What is your email?

from gotraining.

[email protected]

from gotraining.