Git Product home page Git Product logo

Comments (6)

machadoit avatar machadoit commented on August 16, 2024

Hey @jalberto

Thanks for letting us know, we created a ticket to review it, but in case you are interested, we do accept pull requests =)

from ruby-codacy-coverage.

andrebras avatar andrebras commented on August 16, 2024

Hi @jalberto

Recent codacy-coverage versions have added rest-client as a runtime dependency and rest-client dependends on mime-types < 3.0.

So if you have mime-types locked to 3.0 which is fine for actionmailer/mail (mime-types < 4)
breaks rest-client dependencies (mime-types < 3.0)!!

Try installing mime-types 2.99.1 manually, which is good for both, rest-client and mail. Or open your Gemfile.lock, remove references to mime-types (= 3.0) save and blundle again.

Perfect solution would be to update rest-client but this is not so easy, latter releases droped support to ruby 1.9. This is something that @machadoit will have to think about and it depends on what their plattform plans to support!

Hope it helps.

from ruby-codacy-coverage.

machadoit avatar machadoit commented on August 16, 2024

Thanks for your feedback @andrebras,

We still don't know when we'll be able to fit the Rails 5 support in our sprints, but I will keep you posted! =)

from ruby-codacy-coverage.

jalberto avatar jalberto commented on August 16, 2024

thanks @andrebras for the expanded explanation.
@machadoit this is not a simple rails5 problem, is about outdated dependencies, I cannot use this gem in any of my new projects using the latest stable version of mime-types (sinatra, PORO, etc)

Downgrading mime-types is not an option as it will broke lot of stuff.

My suggestion will be, keep a "legacy" tag for people still using ruby < 1.9
then create a new version without rest-client, just using standard net lib

from ruby-codacy-coverage.

machadoit avatar machadoit commented on August 16, 2024

Hey @jalberto @andrebras

As suggested I released a new version for ruby > 1.9 and without rest-client dependency. Let me know if it works well for you guys!

https://github.com/codacy/ruby-codacy-coverage/releases/tag/1.0.0

from ruby-codacy-coverage.

jalberto avatar jalberto commented on August 16, 2024

Seems to post correctly data to Codacy :) (still waiting to see results in codacy though)

Thanks!

from ruby-codacy-coverage.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.