JSHint is not catching "unused" arguments in define? about bullsfirst-jquery-backbone HOT 5 OPEN

Are you referring to this case?

define( [ 
  'module1',
  'module2'
], function(module1) {

  // I don't have a module2 argument

});

or this case?

define([
  'module1',
  'module2'
], function(module1, module2) {

  module1();

  // I don't use module2

});

from bullsfirst-jquery-backbone.

Oh, I see it doing the second one, and neither grunt nor sublime's jshint is catching it. That seems new. I think I was getting the unused errors very recently.

from bullsfirst-jquery-backbone.

Ah, and here's what I just observed: if the unused argument is at the END of the arguments list, JSHint catches it, but not if it's anywhere else in the arguments list.

And here, I found it's intentional JSHint behavior: jshint/jshint@5751c5e

from bullsfirst-jquery-backbone.

Thanks for tracking this down. So the commit happened 5 months ago - does this mean that it has not made it to grunt?

from bullsfirst-jquery-backbone.

No, this is the intended behavior. Unuseds that are followed by useds will not throw an error.

That commit message explains why. I think it should be an optional flag, but that's what we have.

from bullsfirst-jquery-backbone.