Git Product home page Git Product logo

Comments (10)

aralroca avatar aralroca commented on May 14, 2024 2

@aralroca Great news! It works great now. Thanks! 👍

When I was testing it, I've just noticed that modifying files starting with underscore _(document|app).js does not trigger rebuild (in both cmd and bash so it seems to be non-related issue). Is this also happening to you?

Yes. It's a known problem commented on #56, the same thing is happening in /api routes.

Nevertheless, I think that we can fix it now. I'm going to change the milestone of #56 to 0.15.0 in order to prioritize the issue! Thanks to report it!

from next-translate.

aralroca avatar aralroca commented on May 14, 2024 1

Hey @Matasek, yes, the CLI tool for static pages right now is only compatible in Unix. However, thank you to report it. A good consideration is to also support Windows for the CLI. Let's keep open the issue and I will take a look in a few days.

from next-translate.

mataslib avatar mataslib commented on May 14, 2024 1

Hello, I've tried it, it's not working properly yet. It now works in git bash (MinGW) 👍, however still does not work in Win cmd/powershell.

PS: I thank you!

image

from next-translate.

heatseeker76 avatar heatseeker76 commented on May 14, 2024 1

I created a PR to fix the last issue. #111
I tested it on windows. It is working correctly.

from next-translate.

mataslib avatar mataslib commented on May 14, 2024 1

@aralroca Great news! It works great now. Thanks! 👍

When I was testing it, I've just noticed that modifying files starting with underscore _(document|app).js does not trigger rebuild (in both cmd and bash so it seems to be non-related issue). Is this also happening to you?

from next-translate.

heatseeker76 avatar heatseeker76 commented on May 14, 2024 1

Hi @aralroca
Sorry I did not follow the PR I initiated. I was too busy at work and could not follow properly.
I installed and tested it and I just deployed the lastest version to prod.

@aralroca you are exceptional. The fact you took time to explain your change request says a lot about you. 💯

Thanks a lot !

from next-translate.

mataslib avatar mataslib commented on May 14, 2024

Unfurtunately it seems like this library is incompatible with Windows by default.

I've hotfixed those issues by replacing "/" with "\" inside builder.js, but another errors have emerged (like undefined "rm" command...).

I use WSL bash now, it's working just fine in there.

from next-translate.

aralroca avatar aralroca commented on May 14, 2024

Hey @mataslib , this fix will be released on 0.14.0, however, you can try it now in 0.14.0-canary.1, please, can you confirm that it is working on your computer?

https://github.com/vinissimus/next-translate/releases/tag/0.14.0-canary.1

Thank you a lot 👏

from next-translate.

aralroca avatar aralroca commented on May 14, 2024

Ok, in that case, I reopen the issue to fix this on 0.14.2 👍

from next-translate.

aralroca avatar aralroca commented on May 14, 2024

@mataslib @heatseeker76 we created a prerelease 0.14.2-canary.2 with this fix! Can you verify that it works? 👏

from next-translate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.