Support Redis Sentinel mode about harbor-scanner-trivy HOT 5 CLOSED

To be honest @danielpacak, I don't really know whether it has better support. When I researched this, I saw that it has native support for Sentinel but I haven't really looked at the implementation because harbor-scanner-trivy already uses redigo. I will take a quick look and update if anything comes up!

from harbor-scanner-trivy.

Hi @danielpacak
I would like to make the env in harbor configured as

• for in cluster redis
  SCANNER_STORE_REDIS_URL=redis://redis:6379/5
• for sentinel redis
  SCANNER_STORE_REDIS_URL=redis+sentinel://redis-cluster_sentinel_1:26379,redis-cluster_sentinel_2:26379,redis-cluster_sentinel_3:26379/mymaster/5

Is that OK?

from harbor-scanner-trivy.

Hi @danielpacak
I would like to make the env in harbor configured as

• for in cluster redis
  SCANNER_STORE_REDIS_URL=redis://redis:6379/5
• for sentinel redis
  SCANNER_STORE_REDIS_URL=redis+sentinel://redis-cluster_sentinel_1:26379,redis-cluster_sentinel_2:26379,redis-cluster_sentinel_3:26379/mymaster/5

Is that OK?

Hi @bitsf . Yes, I think we can support such URL schema

from harbor-scanner-trivy.

I was trying to implement Redis Sentinel support for harbor-scanner-trivy for quite some time but there isn't a good library that can be readily used. harbor-scanner-trivy uses redigo, which itself doesn't provide Sentinel support. Sentinel is a library that is an extension to redigo for Sentinel support but it implements the protocol described here only partially. What I mean is that the library manages to identify the master and read from/write to it. In case of a failover, the new master is also identified properly. Yet, the library doesn't make use of the slaves. All queries are sent to the master (both read and write), as opposed to writing only to master and load balancing the read queries to the slaves.

from harbor-scanner-trivy.

I was trying to implement Redis Sentinel support for harbor-scanner-trivy for quite some time but there isn't a good library that can be readily used. harbor-scanner-trivy uses redigo, which itself doesn't provide Sentinel support. Sentinel is a library that is an extension to redigo for Sentinel support but it implements the protocol described here only partially. What I mean is that the library manages to identify the master and read from/write to it. In case of a failover, the new master is also identified properly. Yet, the library doesn't make use of the slaves. All queries are sent to the master (both read and write), as opposed to writing only to master and load balancing the read queries to the slaves.

That's great feedback @hrist0stoichev Do you happen to know if this one https://github.com/go-redis/redis has by any chance a better support for Sentinel?

from harbor-scanner-trivy.