Git Product home page Git Product logo

Comments (3)

AqlaSolutions avatar AqlaSolutions commented on September 27, 2024

I'm agree with this but since AddSubType already returns MetaType changing which MetaType is returned will break existing code in a way that it won't be noticed at compile time. Do you think it's possible to solve such case?

from aqlaserializer.

aienabled avatar aienabled commented on September 27, 2024

You can rename the method to something different - for example, RegisterSubType. So developers who use this method will get a compilation error and go here to read about the changes.

But, since nobody reported it before, I think it might be safe to assume that nobody really used the result of this method. So maybe a simple fix with mention about it in the release notes will be good enough.

Regards!

from aqlaserializer.

AqlaSolutions avatar AqlaSolutions commented on September 27, 2024

Closing for now since I'm not going to change this behavior in near future

from aqlaserializer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.