Git Product home page Git Product logo

Comments (4)

cmstead avatar cmstead commented on June 9, 2024

I went ahead and just committed a branch so you can reproduce the problem as well as see the entirety of my configuration and test example.

https://github.com/cmstead/js-refactor/tree/approvalsIssue

To run the tests, clone the project, run npm i and then run npm test.

from approvals.nodejs.

staxmanade avatar staxmanade commented on June 9, 2024

@cmstead For your issue a couple things.

  1. Looks like it's an issue with this line https://github.com/approvals/Approvals.NodeJS/blob/master/lib/Providers/BeforeEachVerifierBase.js#L14 - if the directory doesn't exist it throws and error? I'll file an issue to avoid that error going forward.
  2. If you create the ./test/approvals folder - it ran the tests for me.
  3. I put a ton of work (including an updated BeyondCompare reporter that looks for v4 into the v2.0 release of approvals. Any chance you can grab the latest and see if it'll work for you? in your config you would change your reporters list to look like ['beyondcompare']

from approvals.nodejs.

cmstead avatar cmstead commented on June 9, 2024

Sorry, I should have put an empty file in the approvals folder, git ignores empty folders, sorry about that.

Anyway, I'll give it another go, but the thrown error wasn't the issue, (I expect to see an error thrown and I'm okay with it, and it helped me diagnose what was happening) it was where files were ending up. So strange it worked on your machine, but not mine. Maybe I just need to do a clean install of all packages. Thanks for checking it out.

from approvals.nodejs.

staxmanade avatar staxmanade commented on June 9, 2024

Noticing that (the files are not landing in the specified directory...) I'll see what's going on.

from approvals.nodejs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.