Comments (4)
I went ahead and just committed a branch so you can reproduce the problem as well as see the entirety of my configuration and test example.
https://github.com/cmstead/js-refactor/tree/approvalsIssue
To run the tests, clone the project, run npm i
and then run npm test
.
from approvals.nodejs.
@cmstead For your issue a couple things.
- Looks like it's an issue with this line https://github.com/approvals/Approvals.NodeJS/blob/master/lib/Providers/BeforeEachVerifierBase.js#L14 - if the directory doesn't exist it throws and error? I'll file an issue to avoid that error going forward.
- If you create the
./test/approvals
folder - it ran the tests for me. - I put a ton of work (including an updated BeyondCompare reporter that looks for v4 into the
v2.0
release of approvals. Any chance you can grab the latest and see if it'll work for you? in your config you would change your reporters list to look like['beyondcompare']
from approvals.nodejs.
Sorry, I should have put an empty file in the approvals folder, git ignores empty folders, sorry about that.
Anyway, I'll give it another go, but the thrown error wasn't the issue, (I expect to see an error thrown and I'm okay with it, and it helped me diagnose what was happening) it was where files were ending up. So strange it worked on your machine, but not mine. Maybe I just need to do a clean install of all packages. Thanks for checking it out.
from approvals.nodejs.
Noticing that (the files are not landing in the specified directory...) I'll see what's going on.
from approvals.nodejs.
Related Issues (20)
- .approvalsConfig example should be YAML
- Option to block test progress on diff tool HOT 1
- Approvals.NodeJS pulls `"edge"`, `"edge-cs"`, and `"nan"` dependencies on Windows HOT 1
- Allow specifying a file extension from options override (HTML for instance, helpful to preview in the browser) HOT 1
- Setting up the project fails with ENOTFOUND HOT 1
- Add an IntelliJ reporter
- failOnLineEndingDifferences not working HOT 3
- Cannot read property 'blockUntilReporterExits' of undefined HOT 3
- exitCode always 0 when encountering stale approvals HOT 2
- security issue with `marked` version via `msee` HOT 2
- Empty Files
- DateScrubber.getScrubberFor doesn't support the following:
- Approvals JS and Jest HOT 2
- natives dependency deprecated by its maintainer
- how to use combinationverify HOT 1
- Incorrect version tag in 6.2.1 HOT 3
- Beyond Compare 4 won't ever be found on Windows due to bug
- Issues with Buffer Compare Loop HOT 3
- event-stream flatmap-stream HOT 2
- Callback or promise so I can wait until visual diff editor closes before moving on to the next test? HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from approvals.nodejs.