Look to add a vimdiff reporter about approvals.nodejs HOT 9 CLOSED

This would be great!

If you take a look at various reporters in this folder https://github.com/approvals/Approvals.NodeJS/tree/master/lib/Reporting/Reporters you can get an idea how other diff reporters are implemented.

Also take a look at the tests: https://github.com/approvals/Approvals.NodeJS/tree/master/test/Reporting/Reporters

Hope this helps

from approvals.nodejs.

@staxmanade I would like to work on this,could you provide more context?
Thanks

from approvals.nodejs.

@staxmanade I am looking at the code.Will get back to you soon on this.
Thanks

from approvals.nodejs.

@kytrinyx did this in her ruby version.
https://github.com/kytrinyx/approvals/blob/794cb8b680c095f6b2266d283e99a7914af39db8/lib/approvals/reporters/launcher.rb

from approvals.nodejs.

@isidore But does 'vimdiff' work in windows? You have to launch vim with the -d option right?

from approvals.nodejs.

unsure this was focused on mac

Llewellyn Falco
www.approvaltests.com

On Tue, May 17, 2016 at 8:57 AM, niwsa [email protected] wrote:

@isidore https://github.com/isidore But does 'vimdiff' work in windows?
You have to launch vim with the -d option right?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6 (comment)

from approvals.nodejs.

@staxmanade
Which all platforms (UNIX/OS X/Windows) are to be supported for this reporter?

from approvals.nodejs.

as many as you can - if you can... But if you get it working for one, that's great.

from approvals.nodejs.

closing: https://github.com/approvals/Approvals.NodeJS/blob/master/lib/Reporting/Reporters/vimdiffReporter.js

from approvals.nodejs.