Git Product home page Git Product logo

Comments (5)

jamesrcounts avatar jamesrcounts commented on May 29, 2024

I just tested, and yes npm install is working now. A couple hours ago I updated node on that VM from 5.1.0 to latest 5.3.0.

So it may have been node ver, or the combo of node ver and Win10.

from approvals.nodejs.

staxmanade avatar staxmanade commented on May 29, 2024

Thanks @jamesrcounts

Looking at some of the tests erroring on Win 10 - I don't understand how they're passing on the Mac. (in some cases the .approved.txt files are not even checked into git)... I'll keep digging

from approvals.nodejs.

jamesrcounts avatar jamesrcounts commented on May 29, 2024

I do see some missing approvals. Not sure about them. A couple tests appear to be line ending related. Git may be normalizing the approved file on Windows checkout.

capture

from approvals.nodejs.

staxmanade avatar staxmanade commented on May 29, 2024

Seems to be an issue in the directory it's saving the file to... Can't diagnose it tonight.

from approvals.nodejs.

staxmanade avatar staxmanade commented on May 29, 2024

Some tests are designed to "fail" by not having an approval file on disk (checked in)... Closing as I just pushed a large number of commits (fixing tests and cleanup)

from approvals.nodejs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.