Git Product home page Git Product logo

Comments (5)

jondlm avatar jondlm commented on August 18, 2024

I'm currently working on this one. Will have PR out today.

from lucid.

jondlm avatar jondlm commented on August 18, 2024

Also here's an article detailing the problem a bit more.

from lucid.

jondlm avatar jondlm commented on August 18, 2024

We're debating whether this should be simply value or something else entirely. I'm not a huge fan of using value cause I feel like it's overloaded and doesn't convey the purpose well in a React app. But it's still up for debate.

from lucid.

ogupte avatar ogupte commented on August 18, 2024

My thoughts on what value means and why I think it's an inappropriate prop name for radio/checkbox/item/button/option/etc:

value for input controls is data that should come from the user: like text/password/file/search/etc inputs. Names/IDs are supposed to be defined by the app for identification purposes within the app itself. However, using name or id as a prop name for input controls has some legacy technical/semantic value for certain HTML elements, so it doesn't feel right to repurpose those names (since lucid components pass them thru to the native elements anyways) so reasonably, something like uniqueId makes the most sense to me as a general solution which can be applied to any kind of repeatable component. Also having its default unique ID be the index position in a group eliminates the need to even specify it in most cases, so it's not a prop that will see a lot of direct use by a consumer.

from lucid.

jondlm avatar jondlm commented on August 18, 2024

We're considering returning all the props with a callback signature of ({ event, props }) => {}

from lucid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.