Git Product home page Git Product logo

Comments (2)

Lukasa avatar Lukasa commented on May 27, 2024

What would we do with them?

from swift-nio-http2.

glbrntt avatar glbrntt commented on May 27, 2024

I think we looked at our problem the wrong way. The problem being how to close only the inbound stream when using NIOAsyncChannel. At the moment it closes it on channelInactive, channelError and on the ChannelEvent.inputClosed user inbound event.

The first two aren't appropriate so and we made the mistake of thinking "we need ChannelEvent.inputClosed so we need close0 to support close modes". I think we can just fire the user inbound event when we receive a frame with the end stream flag set, which I think makes sense in this situation.

from swift-nio-http2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.