Extend `UnnecessaryEventHandlerParameter` for constants about detekt-rules-compose HOT 4 OPEN

Hmm. But this rule tries to nudge you to change the first case into letting the parent supply the constant while simplifing the implementation of Foo:

fun main() {
  Foo(onSomething = { doStuff(5) })
}

@Composable
private fun Foo(onSomething: () -> Unit) {
  Button(onClick = onSomething)
}

Wouldn't this work for you?

from detekt-rules-compose.

Ah. I misread the issue. Sorry :)

from detekt-rules-compose.

I agree!

It would be easy to implement for primitive types, but it seems that it would require the type resolution enabled for your example with a sealed class? Otherwise it seems a quite difficult task to find out that SealedClassIntent.Back is actualy an object.

from detekt-rules-compose.

Maybe it is possible to ignore the rule for lambda if its parameter is not derived from composable arguments?
For example:

// GOOD. Lambda parameter created inside the composable
@Composable
private fun Foo(
    onSomething: (Any) -> Unit,
) {
    Button(onClick = { onSomething(5) }) { /*...*/ }
}

// BAD. Lambda parameter derived from composable arguments
@Composable
private fun Foo(
    number: Int,
    onSomething: (Int) -> Unit,
) {
    Button(onClick = { onSomething(number) }) { /*...*/ }
}

from detekt-rules-compose.