Bug in TFileTransport.read(size:)? about thrift-swift HOT 3 OPEN

Oops. That actually won't work because of the while conditional read.count < size. Perhaps instead of writing directly to a Data index like read[position], the UInt8 value could be appended to the empty Data object instead...?

from thrift-swift.

I think it'll work if the object is constructed the same as Data(capacity: size), but within the read loop, it is filled with:

read.append(nextChar)

from thrift-swift.

Hmm good catch, I've not tested the TFileTransport extensively (just barely)
Could you replace the read method with this one and let me know if it fixes your issues?
After a quick test it seems that index addressing doesn't play nice with Data(capacity:) because it just reserved space, instead of fully allocating it to the Data object, so while it has n-bytes capacity to write to, it technically only has 0 bytes (reported by count), and index replacements on Data since its a value type use replaceBytesInRange:withBytes, since the range is {0,0} that obviously doesn't work well does it?

  public func read(size: Int) throws -> Data {
    // set up read buffer, position 0
    var read = Data(capacity: size)
    
    // read character buffer
    var nextChar: UInt8 = 0
    
    // continue until we've read size bytes
    while read.count < size {
      if fread(&nextChar, 1, 1, self.fileHandle) == 1 {
        read.append(nextChar)
      } else {
        throw TTransportError(error: .endOfFile)
      }
    }
    return read
  }

from thrift-swift.