Comments (3)
Hi @derhally , thanks for the input. Certainly understand the flexibility that you're asking for.
@g-greatdevaks created the module so I'll let him chip in. From what I saw in this specific case the module doesn't even use the created subnet but the one passed in via the module param: https://github.com/apigee/terraform-modules/blob/main/modules/nb-psc-l7ilb/main.tf#L79.
In this case just commenting out the network resources on the module should do the trick for you.
I'm leaving this open to consider a clean up and implement more modular defaults.
from terraform-modules.
Thanks for raising the issue.
As Daniel pointed out, the module is flexible to take subnet from the subnet resource or from the module param/variable.
I believe some usage documentation should be added to provide clarity on the same with some examples of passing subnet link(s). One example is shown here.
Will take the documentation task for this issue and update here once done.
Will have some clean up performed with tweaking the module a bit as well.
from terraform-modules.
@g-greatdevaks I'm specifically referring to the resource google_compute_subnetwork.proxy_subnet
not the subnet being used with the google_compute_forwarding_rule
edit:
There are two issues I see, which I apologize for not making it clear in the issue.
-
This module assumes the VPC is in the same project as backend service. Which won't be the case with a shared vpc setup.
-
In a shared VPC setup, the dev team may not have permissions to create a proxy subnets. e.g. In our org, network management is handled by the platform team. Dev teams can't create new subnets.
from terraform-modules.
Related Issues (20)
- Running variables.tf gives below error. please help HOT 1
- Fix PSC Southbound Endpoint Attachment Module HOT 1
- Support using existing VPC
- Unable to pass multiple ssl certificate in module mig-l7xlb HOT 1
- Why does sample x-nb-psc-xlb use two VPCs? HOT 1
- Implement Support for VPC Flow Logs
- Re-use of key rings
- Samples hybrid-gke IAM Project ID bug HOT 1
- Architecture diagram for each sample HOT 1
- Support for environment types - PAYGv2 HOT 4
- <!DOCTYPE html> <html> <head> <title>My Website</title> </head> <body> <h1>My Website</h1> <script> (async function() { const bard = await fetch('https://bard.ai/api/v1/embed').then(response => response.json()); bard.render(document.getElementById('bard-container')); })(); </script> <div id="bard-container"></div> </body> </html>
- Sample "x-l7xlb" causes an invalid key lookup
- Not able to configure "Access Routing" through terraform module/s HOT 2
- mTLS - envoy configuration HOT 7
- Apigee Integration is not shown in the Apigee console. HOT 1
- Northbound PSC sample failing on initial apply HOT 3
- PSC_INGRESS_MODULE HOT 1
- Fix Mega Linter configuration for Linters having disabled errors
- Update Cloud Foundation Fabric Dependencies to Latest Release Version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-modules.