<a href="https://github.com/api3dao/airnode/blob/e07a3b9952e48139f70b1fb7344a6f30b97af

Here as well? <div class="Box-header f

Ignore casing when comparing address in OEV gateway about airnode HOT 3 CLOSED

Siegrift commented on July 22, 2024

Ignore casing when comparing address in OEV gateway

from airnode.

Comments (3)

dcroote commented on July 22, 2024

Here as well?

airnode/packages/airnode-node/src/handlers/sign-oev-data.ts

Line 15 in 1c49d6f

 const beaconsToSign = beacons.filter((beacon) => beacon.airnodeAddress === airnodeAddress); 

Though I'm actually having a hard time understanding how both addresses can be anything but Checksum addresses in the code you linked to:

airnode/packages/airnode-node/src/workers/local-gateways/validation.ts

Lines 277 to 279 in 1c49d6f

 const airnodeWallet = getAirnodeWalletFromPrivateKey(); 

 const airnodeAddress = airnodeWallet.address; 

 if (!beaconsWithIds.some((beacon) => beacon.airnodeAddress === airnodeAddress)) {

Here, airnodeAddress is the Checksum address since that is what ethers within getAirnodeWalletFromPrivateKey() returns. As for beacon.airnodeAddress, it seems this too has to be the Checksum address, since otherwise ethers verifyMessage would fail because the signature, generated with ethers signMessage (right?), returns the Checksum address.

airnode/packages/airnode-node/src/workers/local-gateways/validation.ts

Lines 177 to 182 in 1c49d6f

 const addressFromSignature = ethers.utils.verifyMessage(message, signature!); 

 // Signature doesn't match 

 if (airnodeAddress !== addressFromSignature) { 

 throw new Error('Invalid beacon signature'); 

 }

from airnode.

Siegrift commented on July 22, 2024

I actually wasn't sure just by looking at the code, so I assumed this is possible. If you've verified this is not an issue we can close this one.

from airnode.

Siegrift commented on July 22, 2024

I believe this works as expected.

from airnode.

Recommend Projects

Ignore casing when comparing address in OEV gateway about airnode HOT 3 CLOSED

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	const airnodeWallet = getAirnodeWalletFromPrivateKey();
	const airnodeAddress = airnodeWallet.address;
	if (!beaconsWithIds.some((beacon) => beacon.airnodeAddress === airnodeAddress)) {

	const addressFromSignature = ethers.utils.verifyMessage(message, signature!);
	// Signature doesn't match
	if (airnodeAddress !== addressFromSignature) {
	throw new Error('Invalid beacon signature');
	}