Git Product home page Git Product logo

Comments (2)

adamfranco avatar adamfranco commented on May 28, 2024

Scanning through phpCAS the only problem I see is that phpCAS::setPGTStorage($storage) and the other PGT storage configuration methods must be called after the client is instantiated, but before $client->callback() is called.

Since this change would require all clients to change the order of calls, it probably isn't worth changing now if we can stream the code from within the CAS_Client.

from phpcas.

jfritschi avatar jfritschi commented on May 28, 2024

You are right. I somehow missed that...

Closing the issue. The code is currently at the right place since any kind of authentication function will always hit wasPreviouslyAuthenticated().

Thanks for your second pair of eyes. I somehow knew i was missing something.

from phpcas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.