Git Product home page Git Product logo

Comments (5)

jfritschi avatar jfritschi commented on May 28, 2024

I have added the first few commits of style fixes and will go through all files over the next few days. The changes are all just documentation, naming standards and indentation.

from phpcas.

saltybeagle avatar saltybeagle commented on May 28, 2024

Looking good.

from phpcas.

jfritschi avatar jfritschi commented on May 28, 2024

I did a lot more refactoring and style correction. I have also tried to fix the @author tags for all major contributors. Any comments or suggestions are welcome.

The only outstanding errors are in the Client.php class and /test. They will be fixed in the next few days.

I have not yet bothered to fix warning on a global level. Maybe later ;)

from phpcas.

jfritschi avatar jfritschi commented on May 28, 2024

I think i'm pretty much done with most of the changes

There is only one outstanding error: The naming of the main class "phpCAS" does not conform to the PEAR naming standard but that would be a heavy api change and can't be part of 1.3 anyway.

So we are down to 1 ERROR and ~400 Warning due to being over 85 chars in a single. Nothing major bot very tedious manual work which i will continue to work on over the next few days and weeks.

from phpcas.

jfritschi avatar jfritschi commented on May 28, 2024

Closing this issue and i'm opening an new issue for the warnings.

from phpcas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.