Comments (5)
I have added the first few commits of style fixes and will go through all files over the next few days. The changes are all just documentation, naming standards and indentation.
from phpcas.
Looking good.
from phpcas.
I did a lot more refactoring and style correction. I have also tried to fix the @author tags for all major contributors. Any comments or suggestions are welcome.
The only outstanding errors are in the Client.php class and /test. They will be fixed in the next few days.
I have not yet bothered to fix warning on a global level. Maybe later ;)
from phpcas.
I think i'm pretty much done with most of the changes
There is only one outstanding error: The naming of the main class "phpCAS" does not conform to the PEAR naming standard but that would be a heavy api change and can't be part of 1.3 anyway.
So we are down to 1 ERROR and ~400 Warning due to being over 85 chars in a single. Nothing major bot very tedious manual work which i will continue to work on over the next few days and weeks.
from phpcas.
Closing this issue and i'm opening an new issue for the warnings.
from phpcas.
Related Issues (20)
- PHP 8 redirect issue HOT 4
- Notice PHP : Variable is undefined
- phpunit tests broken in github actions HOT 2
- phpCAS::getAttributes gives me an empty array HOT 7
- No ability to disable displaying errors directly into the response. HOT 2
- Differentiate ErrorException from GracefullTerminationException HOT 1
- deprecation warning in php 8.1.2 HOT 2
- time for new release? HOT 3
- Is there a way to use phpCAS within a Symfony API REST? HOT 1
- Endless Loop, ticket not found HOT 5
- Autoload.php should not emit a composer-preferred warning HOT 3
- Version 1.6.0 is a breaking upgrade and is not compatible with older versions HOT 7
- jasig/phpcas package should be abandoned in favor of apereo/phpcas HOT 9
- login with 1.6.0 wrong redirection HOT 2
- Non-empty $_SESSION array disrupts page caching techniques
- DOMDocument::loadXML(): Argument #1 ($source) must not be empty HOT 2
- phpCAS relies on curl being available HOT 1
- Alternate URL for logout requests HOT 4
- GracefullTerminationException : warning with PHP 8.0 HOT 3
- renewAuthentication doesn't force renew if user already authenticated
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpcas.