[Feature] provides sample option in python agent about skywalking HOT 9 OPEN

fyi @Superskyyy

from skywalking.

Could you briefly describe your idea? Is it possible to dynamically update the value of sample based on the configuration file?

from skywalking.

@CodePrometheus I will achieve the function through following tasks:

1. Add SW_AGENT_SAMPLE in skywalking/config.py
2. Create a sampling_service with try_sampling, reset_sampling_factor and other methods. try_sampling will add one to a counter property of sampling_service. reset_sampling_factor will clear the counter.
3. Modify skywalking/trace/context.py to check if sampling_service.try_sampling returns true every time before creating a new SpanContext. If sampling_service.try_sampling returns false, get_context should return NoopContext.
4. A scheduler thread will be started when initializing a sampling service, it will reset the sampling factor every 3 seconds.

Dynamically updating the value based on the configuration file or environment variables will not be implemented.

from skywalking.

Could you briefly describe your idea? Is it possible to dynamically update the value of sample based on the configuration file?

@CodePrometheus Could you be more specific about this? What do you mean based on file?

The above logic seems to be as same as Java agent sampling.

from skywalking.

@CodePrometheus Could you be more specific about this? What do you mean based on file?

The above logic seems to be as same as Java agent sampling.

Yes, the above logic is similar to the existing sample_n_per_3_secs in Java agent. I want to refer to dynamic configuration, ref #6114

from skywalking.

I am not sure whether python agent supports dynamic configuration in the kernel already? @Superskyyy

from skywalking.

I am not sure whether python agent supports dynamic configuration in the kernel already? @Superskyyy

Currently, this capability is not implemented in python-agent.

from skywalking.

@tsonglew Are you going to add this too?

from skywalking.

@tsonglew Are you going to add this too?

Yes, I will create another mr for config change events

from skywalking.