Comments (9)
@pjfanning Yes,
org.apache.pekko.japi.pf.PFBuilder
.
Thanks - there seem to be some useful classes in the org.apache.pekko.japi.pf
package.
https://pekko.apache.org/japi/pekko/current/org/apache/pekko/japi/pf/package-summary.html
from pekko.
@He-Pin what do you think we should do here? Should we document the issue we see in apache/pekko-persistence-cassandra#212 or is there a change we can make to stream-testkit to avoid the issue going forward?
from pekko.
I was expected to avoid a double evaluation, but that can only be done with 2.13, we may better go with 2.13 abd I expect drop the 2.12 support in 1.2.x anyway
from pekko.
@He-Pin This new method in https://github.com/He-Pin/incubator-pekko/blob/05248075bd13a336c9af079cb44a61986dc1f751/stream-testkit/src/main/scala/org/apache/pekko/stream/testkit/StreamTestKit.scala#L869 doesn't make sense to me. The PartialFunction is a Scala function, not a Java function. This seems like a not very useful Java API. The other changes in #1186 seem mainly ok to me but could we consider these?
- removing the Java API expectNextWithTimeoutPF
- or changing the Java API expectNextWithTimeoutPF to use a Java function.
When I say the other changes in #1186 are mainly ok, there are other new Java API methods that take Scala Partial Functions as inputs.
How do Java users even create a Scala Partial Function?
from pekko.
Yes, but a user can build a PartialFunction with the helper, such as the Receive builder.
from pekko.
Yes, but a user can build a PartialFunction with the helper, such as the Receive builder.
The ReceiveBuilder will not work for this stream-testkit use case. Unless we have a builder that can build a PartialFunction[Any, T]
- does that exist?
from pekko.
@pjfanning Yes, org.apache.pekko.japi.pf.PFBuilder
.
from pekko.
@He-Pin what do you think we should do here? Should we document the issue we see in apache/pekko-persistence-cassandra#212 or is there a change we can make to stream-testkit to avoid the issue going forward?
If I understand correctly this is only an issue when using Scala 2.12, right? In that case I think the note in #1403 seems sufficient and IMHO we can close this issue (or keep it open for if anyone is interested in looking into it, but remove it from the 1.1.0 milestone)
from pekko.
I'll close this. It is documented and I think the consensus is not to fix it.
from pekko.
Related Issues (20)
- handle the case where `DeviceTerminated.groupId` may not match the `DeviceGroup.groupId` HOT 2
- review test dependency overrides associated with docker-java
- java.lang.UnsupportedOperationException pekko migration HOT 5
- EventSourcedBehavior/Durable State exposed to stack overflow when lots of read-only commands are in the stash HOT 6
- Reproducible Scala 3 artifacts HOT 1
- With entity passivation enabled the shard region will cause a lot of unhandled ShardsUpdated during shutdown
- Feature request: Add BoundedSourceQueue#isComplete method
- double "a" appearing in tutorial HOT 2
- Add FutureTimeoutSupport#timeout support HOT 4
- Add UntypedAbstractActorWithTimers
- Add Flow#onBackpressureDrop() operator HOT 2
- Support just warning instead of error when `pekko.scheduler.tick-duration` < 10ms on Windows?
- Bug - Assertion failure caused by exception during pre-start HOT 3
- long running tests should be run in a nightly build HOT 2
- Deprecate `org.apache.pekko.dispatch.Futures` HOT 3
- Attribute overriding in `SourceQueueWithComplete`
- jdk9 tests do not run HOT 1
- Feature: backoff for Pattern#retry
- Feature Request: Streamlined approach for Behavior Factory
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pekko.