ORC-1121: Predicate pushdown does not work about orc HOT 8 CLOSED

I'll do some investigation later

from orc.

Thank you for reporting, @PengleiShi . Could you make a PR for that?

I'am willing to try.

from orc.

I reviewed SchemaEvolution.java and determined that it was a bug.
I think maybe we can initialize a map to store fileTypeId to readTypeId via readerFileTypes.

Map<Integer, Integer> typeIdsMap = new HashMap<>();

for (int i = 0; i < this.readerFileTypes.length; i++) {
  this.typeIdsMap.put(readerFileTypes[i].getId(), i);
}

public boolean isPPDSafeConversion(final int colId) {
  if (hasConversion()) {
    Integer readTypeId = typeIdsMap.get(colId);
    return readTypeId != null &&
        ppdSafeConversion[readTypeId];
  }

  // when there is no schema evolution PPD is safe
  return true;
}

Welcome @PengleiShi for making this pr. 🍻

from orc.

Thank you for reporting, @PengleiShi . Could you make a PR for that?

from orc.

cc @pgaref , @williamhyun , @guiyanakuang

from orc.

@guiyanakuang Thanks, I'll do it. And should i open a new issue in Jira?

from orc.

Yes, we need the PR prefix to be associated with Jira.

from orc.

This is resolved via #1055

from orc.