Git Product home page Git Product logo

Comments (4)

rabbah avatar rabbah commented on June 14, 2024 1

As a separate project, we need to have the tests written in Go, and establish the test environment in Travis.

define the purpose of the tests first.
if these are unit tests, it makes sense to have the tests in the same language framework as the rest of the code.

if there are integration tests, i would reconsider.

from openwhisk-cli.

houshengbo avatar houshengbo commented on June 14, 2024 1

@rabbah @dubeejw @mdeuser From my perspective, it is also good for us to keep the integration tests consistent with the development language as well. This lows the bar for new contributors coming into this project, and reduces the complexity of setting up this project. Folks won't have the confusion of why to maintain the development and test in two languages.

from openwhisk-cli.

mrutkows avatar mrutkows commented on June 14, 2024

@houshengbo agree with the intent; however, if we have existing tests that need to be rewritten to Go, then we should treat that as a lower priority over the general separation/plugable framework goal. Of course we should identify new tests and their purpose as @rabbah indicated above and record those each as issues of their own. This issue sounds more like a general epic (goal) or placeholder and doubt it can carry all possible tests/code.

from openwhisk-cli.

rabbah avatar rabbah commented on June 14, 2024

We have started suites for such test here:
https://github.com/apache/incubator-openwhisk-cli/blob/master/commands/trigger_test.go
https://github.com/apache/incubator-openwhisk-cli/blob/master/commands/action_test.go

It should be a matter of project policy now to add tests for new functionality here and grow the suite. There are certain features that are easier to test this way.

from openwhisk-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.