Git Product home page Git Product logo

Comments (6)

Zakelly avatar Zakelly commented on May 29, 2024

I guess the return value OK should also be treat as passed.

from kvrocks.

jihuayu avatar jihuayu commented on May 29, 2024

Thank you! @Zakelly
It seems like some commands return value has some wrong.

[('setex', 'foo_ex', 7200, 2), True]

It may "OK" not True.

These codes were introduced in #1963.

Is it possible that the issue is due to different versions of Python Redis client?

from kvrocks.

Zakelly avatar Zakelly commented on May 29, 2024

@jihuayu
My redis-cli and redis-server version are both 7.2.4, when I run setex command in redis-cli, it returns:

127.0.0.1:6379> setex foo_ex 7200 2
OK

Redis python module version:

pip3 show redis   
Name: redis
Version: 2.10.3
Summary: Python client for Redis key-value store
Home-page: http://github.com/andymccurdy/redis-py
Author: Andy McCurdy
Author-email: [email protected]
License: MIT
Location: /Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages
Requires: 
Required-by: 

from kvrocks.

jihuayu avatar jihuayu commented on May 29, 2024

@Zakelly
Thank you for discovering this issue. The test for kvrocks2redis has not been run in CI, which may be a hidden bug.

After the fix it, do you want to add this test to our CI? refer: #1976

from kvrocks.

Zakelly avatar Zakelly commented on May 29, 2024

@jihuayu Yes I'd like to. Please assign to me, Thanks

from kvrocks.

Zakelly avatar Zakelly commented on May 29, 2024

It seems the README is providing the wrong redis-py version. When I changed to 5.0.3, the problem solved.

from kvrocks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.