Git Product home page Git Product logo

Comments (1)

chrisdutz avatar chrisdutz commented on September 20, 2024

Digging a bit further, I think it's probably better to not calculate the offset in the constructor of the filter, but to get it from the dates being used.

So removing the zoneOffset from the base class and doing things like this also made the test return to green.

public class MonthIntervalUSFillFilter extends AbstractMonthIntervalFillFilter {

  public MonthIntervalUSFillFilter(int monthDuration, long nonMonthDuration, ZoneId zone) {
    super(monthDuration, nonMonthDuration, zone);
  }

  @Override
  public boolean needFill(long time, long previousTime) {
    long smaller = Math.min(time, previousTime);
    long greater = Math.max(time, previousTime);
    Instant smallerInstant = Instant.ofEpochSecond(smaller / 1_000_000L, smaller % 1_000_000L);
    LocalDateTime smallerDateTime = LocalDateTime.ofInstant(smallerInstant, zone);
    ZoneOffset smallerOffset = zone.getRules().getStandardOffset(smallerInstant);
    Instant upper =
            smallerDateTime
            .plusMonths(monthDuration)
            .plus(nonMonthDuration, MICROS)
            .toInstant(smallerOffset);
    long timeInUs =
        upper.getLong(ChronoField.MICRO_OF_SECOND) + upper.getEpochSecond() * 1_000_000L;
    return timeInUs >= greater;
  }
}

from iotdb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.