Git Product home page Git Product logo

Comments (13)

AlbumenJ avatar AlbumenJ commented on June 12, 2024 1

Hi, I am new to Dubbo community and willing to complete this task.

Is there any restriction on this issue? For example, in terms of completion time and code quality.

  1. We have no completion time limitation
  2. For code quality, we have add a lot of checkers in Github Actions and we will check it when pull request reviewing

from dubbo.

AlbumenJ avatar AlbumenJ commented on June 12, 2024 1

And, regarding the implementation of local cache, since you mentioned that it will be used as a fallback solution, I think it only needs to be implemented in memory (for example, through a Map ) without the need to store it in the disk (like Nacos) , because it is a small probability event after all.

The main purpose is to save in the disk. To prevent if registry crashed Dubbo cannot start.

from dubbo.

finefuture avatar finefuture commented on June 12, 2024

What scenarios need this feature? In general, the registry sdk already supports local cache.

from dubbo.

AlbumenJ avatar AlbumenJ commented on June 12, 2024

What scenarios need this feature? In general, the registry sdk already supports local cache.

  1. zookeeper not support
  2. Nacos's local cache is not useful for Dubbo. Nacos will use local cache by highest priority, but Dubbo only want it as the fallback.

from dubbo.

FAWC438 avatar FAWC438 commented on June 12, 2024

Hi, I am new to Dubbo community and willing to complete this task.

Is there any restriction on this issue? For example, in terms of completion time and code quality.

from dubbo.

FAWC438 avatar FAWC438 commented on June 12, 2024

Hi @AlbumenJ, I checked the relevant code and documentation, and I think the "local cache" mentioned in this issue actually refers to the consumer caching information such as the provider's ip:port obtained from the registry that is not down. Is that correct?

I did see the local caching function of metadata in the code, but as far as I know from reading the documentation, the metadata link maintained by Dubbo does not actually require the participation of the Service Discovery registry(Nacos or Zookeeper etc.), so does the work of this issue actually have nothing to do with metadata ?

And, regarding the implementation of local cache, since you mentioned that it will be used as a fallback solution, I think it only needs to be implemented in memory (for example, through a Map ) without the need to store it in the disk (like Nacos) , because it is a small probability event after all.

from dubbo.

walkinggo avatar walkinggo commented on June 12, 2024

And, regarding the implementation of local cache, since you mentioned that it will be used as a fallback solution, I think it only needs to be implemented in memory (for example, through a Map ) without the need to store it in the disk (like Nacos) , because it is a small probability event after all.

The main purpose is to save in the disk. To prevent if registry crashed Dubbo cannot start.

Indeed, you can use serialization interfaces to save information on the local disk. However, if users tamper with the files storing this information, it can lead to data security issues. Unauthorized changes might corrupt the data, introduce errors, or cause security vulnerabilities if sensitive data is exposed or manipulated.

from dubbo.

walkinggo avatar walkinggo commented on June 12, 2024

Hey, I want to help too, can you provide more detailed information? For example, what is the local specific information storage location and storage form. @AlbumenJ

from dubbo.

AlbumenJ avatar AlbumenJ commented on June 12, 2024

Hey, I want to help too, can you provide more detailed information? For example, what is the local specific information storage location and storage form. @AlbumenJ

You can check the related example in org.apache.dubbo.registry.support.AbstractRegistry

from dubbo.

walkinggo avatar walkinggo commented on June 12, 2024

Firstly,we should make the zookeeper support the local cache.Secondly,we should make the nacos implements the fallback.It's the all the tasks need to finish in this issue?

from dubbo.

AlbumenJ avatar AlbumenJ commented on June 12, 2024

Firstly,we should make the zookeeper support the local cache.Secondly,we should make the nacos implements the fallback.It's the all the tasks need to finish in this issue?

We can make it more common and not depend on the specific registry.

from dubbo.

walkinggo avatar walkinggo commented on June 12, 2024

I test it, and i find out that dubbo cannot work if registry is down.I can check it is true when registry is zookeeper or nacos.And also,i can see the org.apache.dubbo.registry.support.AbstractRegistry will store the local cache when localCacheEnabled is true.I think the way to finish it is read the local cache when the registry cannot be connected.

from dubbo.

AlbumenJ avatar AlbumenJ commented on June 12, 2024

I test it, and i find out that dubbo cannot work if registry is down.I can check it is true when registry is zookeeper or nacos.And also,i can see the org.apache.dubbo.registry.support.AbstractRegistry will store the local cache when localCacheEnabled is true.I think the way to finish it is read the local cache when the registry cannot be connected.

Yep, you're right. BTW, we should make sure Dubbo will try to reconnect the broken registry continuously.

from dubbo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.