Comments (5)
hmm, i can think of some scenarios where you would want to keep the same volumes, for example in the druid-operator (https://github.com/datainfrahq/druid-operator) a lot of druid configs and certs and things like this are mounted as volumes and we would want some of those things on the peon. at least if we removed volumes we would want to add a config to specify them again.
in general I think that if you need to do more customizations than the overlord podSpec inheriting adapter allows I would prefer using the PodTemplateTaskAdapter to just include the whole custom pod template instead to avoid adding a ton of configs for each thing that can be overwritten in a pod template
from druid.
Hi, @georgew5656 do you think this is reasonable or not? 😄
from druid.
@georgew5656 Thanks for the clarification, previously we met an issue, which is, our K8s cluster will automatically add some volume mount when launching pod, as the Peon podSpec is inherited from Overlord, so when launching the Peon pod, volume mount will be added again and cause duplicate config issue, and Peon fail to start.
We also consider using PodTemplateTaskAdapter
, but whose config entry seems not the same as K8sTaskAdapter
, which means we need to maintain two different yaml setting file
Now we had found some workaround which is, adding a specific label(which can be config via druid.indexer.runner.labels
) to the Peon podSpec before it launch, to tell the k8s cluster not appending volume config to this pod.
It should be working as aspected.
from druid.
that seems reasonable, if we want to add this feature i would put it behind a new config (clearVolumeMountForPeons) or something
from druid.
Related Issues (20)
- Unconditiional join query with SQL which was working on 25.0.0 not working on 29.0.0 it must have broken somewhere in between
- [Draft] 29.0.1 Release Notes
- Kafka with topicPattern can ignore old offsets spuriously
- Windowing query fails when wrapped in an outer select
- Null values on streaming ingestion of proto2 messages
- Encountered test failed when running test from `kubernetes-overlord-extensions` module
- Explore API
- KafkaTuningConfiguration spec is incorrectly documented & Implemented
- /v2 and /v2/candidates endpoints not respecting broker partition pruning - range partition HOT 2
- supervisor endpoint not respecting frontCoded indexSpec formatVersion HOT 2
- Is druid.segmentCache.locations is used to configure the maximum storage size for hot data?
- MiddleManager errors while executing the peon task HOT 3
- Overlord cannot respond to requests when kafka is abnormal
- Ingestion lag because of multiple checkpoints. HOT 1
- yo
- Need a way to distribute ingestion task replicas across tiers
- Ingestion tasks fail because of problem with HDFS
- druid datasource delete automatically [only unused data sources]
- MSQ exporting fails to output headers with complex column types (array/json) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from druid.