Git Product home page Git Product logo

Comments (4)

Dandandan avatar Dandandan commented on May 24, 2024 1

FYI @metesynnada I'm working on a prototype.

Translated the code out of https://dare.uva.nl/search?identifier=5ccbb60a-38b8-4eeb-858a-e7735dd37487 to this, which seems roughly equivalent:

    let mut to_check: Vec<(u64, usize)> = hash_values
        .iter()
        .enumerate()
        .flat_map(|(row, hash_value)| {
            build_hashmap
                .map
                .get(*hash_value, |(hash, _)| *hash_value == *hash)
                .map(|(_, v)| (*v - 1, row))
        })
        .collect();

    while to_check.len() > 0 {
        // TODO Perform column-wise (vectorized) equality check

        // check next items
        to_check = to_check
            .iter()
            .flat_map(|(index, row)| {
                let next = build_hashmap.next[*index as usize];
                (next != 0).then(|| (next - 1, *row))
            })
            .collect();
    }

from datafusion.

Dandandan avatar Dandandan commented on May 24, 2024 1

Yeah - we sure have to test real-world performance :)

from datafusion.

metesynnada avatar metesynnada commented on May 24, 2024

I will be thinking about this as well. Building an array for the equality check might improve the equality check performance, however, compute::take will copy the elements so I am not sure without a performance test on different cases.

from datafusion.

Dandandan avatar Dandandan commented on May 24, 2024

Looks like on TPC-H we get some nice improvements overall #6724

from datafusion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.