Git Product home page Git Product logo

Comments (5)

returnString avatar returnString commented on May 24, 2024 2

I though that dependencies could only be declared in Cargo.toml. Or is the idea that we use pub use arrow::* in datafusion/arrow.rs, and ask people to use use datafusion::arrow::X instead of arrow::X in their crates?

Yeah, my understanding here is we'd use the latter approach of explicitly reexporting arrow. It'd still be possible for people to declare a dependency on arrow and use it directly, but the datafusion::arrow reexport would allow for people to get an appropriate version of arrow by default, rather than having to manually upgrade deps in lockstep :)

from datafusion.

returnString avatar returnString commented on May 24, 2024

I'll take this later today if no-one else wants to claim it immediately :)

from datafusion.

jorgecarleitao avatar jorgecarleitao commented on May 24, 2024

I though that dependencies could only be declared in Cargo.toml. Or is the idea that we use pub use arrow::* in datafusion/arrow.rs, and ask people to use use datafusion::arrow::X instead of arrow::X in their crates?

from datafusion.

jorgecarleitao avatar jorgecarleitao commented on May 24, 2024

Makes a lot of sense to me 👍

I think we will need to remember to bump datafusion's major whenever we bump arrow's major in Cargo.toml, as datafusions' public API will now contain arrows' public API (right?)

from datafusion.

alamb avatar alamb commented on May 24, 2024

Thank you @returnString !

from datafusion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.