Enable all clippy lints about datafusion HOT 4 CLOSED

If someone has time to remove any manual allows that would be awesome

@alamb I'm currently working on a PR that removes a large amount of either unneeded or trivially fixable clippy allows.

Mosts of the remaining lints should be fixed, but are either breaking or generally introduce changes that I'm not comfortable making fixes for. These ones I commented to thoroughly clarify the reason for the lint and potential fixes.

I'll submit the PR soon and then we can discuss the specifics.

Cheers!

from datafusion.

@alamb is this issue still relevant? I was looking for an issue to chew on as a soft introduction to the code base, but I think this issue has already been solved, at least partially?

I still see a number of manual clippy allows in the current code, but it's not immediately clear if these are intended to be fixed or not.

from datafusion.

The command I use to run clippy is cargo clippy --workspace --all-targets -- -D warnings. Besides those manually "allowed", our codebase now doesn't contain clippy warnings

from datafusion.

Thank you @LouisGariepy and @waynexia -- I agree this is no longer relevant

I did a double check of clippy lints that were manually allowed : https://github.com/search?q=repo%3Aapache%2Farrow-datafusion+clippy+allow+language%3ARust&type=code&l=Rust

And while some of them (like redundant_clone could probably be cleaned up) I didn't see anything drastic required.

If someone has time to remove any manual allows that would be awesome

from datafusion.