Comments (4)
At the point of push down filter
, we no longer have Expr::Unnest
but Expr::Column or Expr::BinaryExpr
expr: BinaryExpr(BinaryExpr { left: Column(Column { relation: None, name: "unnest(t.a)" }), op: Gt, right: Literal(Int32(3)) })
Instead of checking whether there is unnest
contained in filter expression, should we move the conversion of Expr::Unnest to LogicalPlan::Unnest try_process_unnest
to the optimization step, specifically at some point AFTER push down filter step? I think we can check whether unnest
exists by Expr::Unnest
, and also I think we don't need to specialize LogicalPlan::Unnest
in push down filter
step, we can deal with LogicalPlan::Projection
only, Expr::Unnest should be part of the LogicalPlan::Unnest
. After push down filter
, we convert Expr::Unnest to LogicalPlan::Unnest
But ideally logical plan optimization should be optional, which means even the optimization step is skipped, we still expect to get the result. Based on this, it might not be a good idea to move the conversion to optmization step 🤔
from datafusion.
It seems to be supported on the main branch.
DataFusion CLI v39.0.0
> create table t (a int[]) as values ([1,2,3]), ([4,5,6]);
0 row(s) fetched.
Elapsed 0.030 seconds.
> select ua from (select unnest(a) as ua from t) where ua > 3;
+----+
| ua |
+----+
| 4 |
| 5 |
| 6 |
+----+
3 row(s) fetched.
Elapsed 0.009 seconds.
from datafusion.
It seems to be supported on the main branch.
DataFusion CLI v39.0.0 > create table t (a int[]) as values ([1,2,3]), ([4,5,6]); 0 row(s) fetched. Elapsed 0.030 seconds. > select ua from (select unnest(a) as ua from t) where ua > 3; +----+ | ua | +----+ | 4 | | 5 | | 6 | +----+ 3 row(s) fetched. Elapsed 0.009 seconds.
I still get the error 🤔
from datafusion.
It seems to be supported on the main branch.
DataFusion CLI v39.0.0 > create table t (a int[]) as values ([1,2,3]), ([4,5,6]); 0 row(s) fetched. Elapsed 0.030 seconds. > select ua from (select unnest(a) as ua from t) where ua > 3; +----+ | ua | +----+ | 4 | | 5 | | 6 | +----+ 3 row(s) fetched. Elapsed 0.009 seconds.I still get the error 🤔
Ok, my bad. It is introduced by the latest PR #10974
from datafusion.
Related Issues (20)
- Move `sql_compound_identifier_to_expr` to `ExprPlanner` HOT 6
- DataFusion weekly project plan (Andrew Lamb) - July 15, 2024 HOT 1
- Release DataFusion `41.0.0`
- ExprPlanner not propagated to SqlToRel HOT 7
- Update the parquet code `prune_pages_in_one_row_group` to use the `StatisticsExtractor`
- Optimize CASE WHEN for "expression or null" case HOT 1
- Add has_side_effects to PhysicalExpr HOT 1
- `SanityCheckPlan` Error during planning: ... does not satisfy parent order requirements: ... HOT 1
- Move spill related functions to `spill.rs` HOT 5
- Consolidate optimizer readme into datafusion user guide HOT 2
- Reduce repetition in `try_process_group_by_unnest` and `try_process_unnest`
- Investigate memory use in debug builds for deeply nested array constants
- [EPIC] Extract physical optimizer out of core
- Leverage dictionary-encode when turning a scalar columnar value into an array HOT 1
- [Proposal] Decouple logical from physical types
- Chore: fix typos in the code
- Explore Updating VariadicAny Signature to take 0 Args HOT 1
- Resources exhuasted errors are confusing return the biggest memory consumers. HOT 3
- `SHOW NONSENSE` does not error
- chroe: Add `SessionState` to `MockContextProvider` just like `SessionContextProvider`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from datafusion.