Comments (3)
Seems like a good idea to me
from datafusion.
Where is there best place in the code base to add a test case for this?
sqllogictests are a good place to start. You can do a COPY
with partitions and the new option toggled, then create a table on just a single partition path, and do a select that verifies the partition column is in the file.
If we want to allow to pass this flag as part of the COPY command (ie COPY (...) TO (...) STORED AS FILE_FORMAT (OPTIONS keep_partition_by_columns true)), what would be the right way to pass this flag to hive_style_partitions_demuxer?
You could check for the new option in source_option_tuples
and then update FileSinkConfig
to hold that option and flow it through to the relevant functions. The relevant physical planner code is here
from datafusion.
I spent some time looking into how to implement this. I have a very basic change that I think would bring the functionality:
main...hveiga:datafusion:issue-10971
I am looking for guidance on two aspects:
- Where is there best place in the code base to add a test case for this?
- If we want to allow to pass this flag as part of the
COPY
command (ieCOPY (...) TO (...) STORED AS FILE_FORMAT (OPTIONS keep_partition_by_columns true)
), what would be the right way to pass this flag tohive_style_partitions_demuxer
?
I see that sql/src/parser.rs
can parse the option and keep it the CopyTo
struct under options
, and then those get used to configure the different FormatOptions
for the different output formats. This particular flag would apply to all formats I believe. Should I add it as another config to TableOptions
?
Thanks!
from datafusion.
Related Issues (20)
- Add example for writing a `FileFormat` HOT 3
- Add `union_tag` function HOT 1
- Add `union_extract` function HOT 1
- Add more support for ScalarValue::Float16 where Float32 and Float64 are supported HOT 1
- Nullability of array_agg
- Allow casting durations to different timeunits
- `gcd` returns negative results HOT 1
- Methods should return `&Arc` references to inner trait objects for `&self` HOT 1
- Excessive number of filters overflows the stack HOT 4
- `LCM` panicked due to overflow
- Running tests uses 50.1GB on Ubuntu HOT 3
- DataFusion weekly project plan (Andrew Lamb) - June 24, 2024 HOT 1
- Make Eq with negative float zero compat with other engines
- Support `Decimal` and `Decimal256` Parquet Data Page Statistics HOT 1
- Support `Timestamp` Parquet Data Page Statistics HOT 4
- Support `Date` Parquet Data Page Statistics HOT 1
- Support `Time` Parquet Data Page Statistics HOT 3
- regression: query error with case when as the group field HOT 5
- ScalarValue::new_ten error cites one not ten
- Support Map as a ScalarValue
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from datafusion.