Git Product home page Git Product logo

Comments (6)

marvinlanhenke avatar marvinlanhenke commented on June 27, 2024

Probably this is the reason why...both str are simply compared. I'm not sure if it makes sense to just 'add' another rule when checking...or if one has to come up with a better fix / design if there are other cases that have to be supported or checked as well?

from datafusion.

samuelcolvin avatar samuelcolvin commented on June 27, 2024

Technically now() is wrongly defined, it explicitly states it's in "UTC" in the docs.

from datafusion.

samuelcolvin avatar samuelcolvin commented on June 27, 2024

I'd be happy to create a pool to start adding special cases, but that sounds like a rabbit hole.

from datafusion.

alamb avatar alamb commented on June 27, 2024

I think the chrono-tz crate has the special cases / knows how to handle converting "UTC" to "+0:00" so I don't think we would have to make a special datafusion map

The arrow crate has a "chrono-tz" feature which activates it. I wonder if we have to turn that on somewhere 🤔 https://crates.io/crates/arrow or maybe use an appropriate check in datafusion

from datafusion.

alamb avatar alamb commented on June 27, 2024

I am responding to @marvinlanhenke 's comment #10960 (comment)

Since "+00:00" and "UTC" are the 'same' - is this viable? Or do we have to extend the logic here in order to provide both variants (and possibly not introduce a breaking change)?

I think that "UTC" == "+00:00" might be a reasonable special case to include

So perhaps we could update the timezone comparison check to compare those two types the same 🤔

from datafusion.

alamb avatar alamb commented on June 27, 2024

#10960 from @marvinlanhenke is up for review 🙏

from datafusion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.