Comments (6)
Probably this is the reason why...both str
are simply compared. I'm not sure if it makes sense to just 'add' another rule when checking...or if one has to come up with a better fix / design if there are other cases that have to be supported or checked as well?
from datafusion.
Technically now()
is wrongly defined, it explicitly states it's in "UTC" in the docs.
from datafusion.
I'd be happy to create a pool to start adding special cases, but that sounds like a rabbit hole.
from datafusion.
I think the chrono-tz crate has the special cases / knows how to handle converting "UTC" to "+0:00" so I don't think we would have to make a special datafusion map
The arrow crate has a "chrono-tz" feature which activates it. I wonder if we have to turn that on somewhere 🤔 https://crates.io/crates/arrow or maybe use an appropriate check in datafusion
from datafusion.
I am responding to @marvinlanhenke 's comment #10960 (comment)
Since "+00:00" and "UTC" are the 'same' - is this viable? Or do we have to extend the logic here in order to provide both variants (and possibly not introduce a breaking change)?
I think that "UTC" == "+00:00"
might be a reasonable special case to include
So perhaps we could update the timezone comparison check to compare those two types the same 🤔
from datafusion.
#10960 from @marvinlanhenke is up for review 🙏
from datafusion.
Related Issues (20)
- Add example for writing a `FileFormat` HOT 3
- Add `union_tag` function HOT 1
- Add `union_extract` function HOT 1
- Add more support for ScalarValue::Float16 where Float32 and Float64 are supported HOT 1
- Nullability of array_agg
- Allow casting durations to different timeunits
- `gcd` returns negative results HOT 1
- Methods should return `&Arc` references to inner trait objects for `&self` HOT 1
- Excessive number of filters overflows the stack HOT 4
- `LCM` panicked due to overflow
- Running tests uses 50.1GB on Ubuntu HOT 3
- DataFusion weekly project plan (Andrew Lamb) - June 24, 2024 HOT 1
- Make Eq with negative float zero compat with other engines
- Support `Decimal` and `Decimal256` Parquet Data Page Statistics HOT 1
- Support `Timestamp` Parquet Data Page Statistics HOT 4
- Support `Date` Parquet Data Page Statistics HOT 1
- Support `Time` Parquet Data Page Statistics HOT 3
- regression: query error with case when as the group field HOT 5
- ScalarValue::new_ten error cites one not ten
- Support Map as a ScalarValue
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from datafusion.