Git Product home page Git Product logo

Comments (3)

yyy1000 avatar yyy1000 commented on July 23, 2024

I'd like to try this, from the description,

Until the partition by parsing uses ColumnDef

So maybe trying to make partition by use ColumnDef, currently, my plan is:

  1. Make table_partition_cols field in
    pub table_partition_cols: Vec<String>,
    CreateExternalTable statement to Vec<ColumnRef>
  2. make parse_partitions return ColumnRef like parse_columns.
    fn parse_partitions(&mut self) -> Result<Vec<String>, ParserError> {
  3. In external_table_to_plan, do the same thing to table_partition_cols like column_defaults
    let column_defaults = self
    .build_column_defaults(&columns, &mut planner_context)?
    .into_iter()
    .collect();

So this will not convert the Ident value to string too early, but I also doubt whether it would fix this. I encountered similar issue related to ' characters in my past experience and it's a bit tricky.

from arrow-datafusion.

alamb avatar alamb commented on July 23, 2024

@metesynnada I wonder if you have any thoughts on the suggestion above from @yyy1000 ?

from arrow-datafusion.

metesynnada avatar metesynnada commented on July 23, 2024

I believe this is a good start.

from arrow-datafusion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.