Comments (4)
alamb
commented on June 26, 2024
1
If you are saying that floor(decimal) should return decimal that makes sense to me
from arrow-datafusion.
Ted-Jiang
commented on June 26, 2024
1
If you are saying that
floor(decimal)should returndecimalthat makes sense to me
Yes, basiclly all numeric type should have the return type same as input.
And i have check the numeric type list is same as pg.
from arrow-datafusion.
Ted-Jiang
commented on June 26, 2024
seems cast in some place
❯ explain verbose select floor(-1);
+------------------------------------------------------------+--------------------------------------------------------------------------------------------------------+
| plan_type | plan |
+------------------------------------------------------------+--------------------------------------------------------------------------------------------------------+
| initial_logical_plan | Projection: floor(Int64(-1)) |
| | EmptyRelation |
| logical_plan after inline_table_scan | SAME TEXT AS ABOVE |
| logical_plan after type_coercion | Projection: floor(CAST(Int64(-1) AS Float64)) |
| | EmptyRelation |
| logical_plan after count_wildcard_rule | SAME TEXT AS ABOVE |
| analyzed_logical_plan | SAME TEXT AS ABOVE |
| logical_plan after eliminate_nested_union | SAME TEXT AS ABOVE |
| logical_plan after simplify_expressions | Projection: Float64(-1) AS floor(Int64(-1)) |
| | EmptyRelation |
| logical_plan after unwrap_cast_in_comparison | SAME TEXT AS ABOVE |
| logical_plan after replace_distinct_aggregate | SAME TEXT AS ABOVE |
| logical_plan after eliminate_join | SAME TEXT AS ABOVE
from arrow-datafusion.
maruschin
commented on June 26, 2024
@alamb, @Ted-Jiang, hi! I created draft PR
if the idea is ok, would like to compare all return types in pg and fixed them
from arrow-datafusion.
Related Issues (20)
- Improve performance for grouping by variable length columns (strings) HOT 3
- Update ClickBench benchmarks with DataFusion 36 HOT 14
- Add a runtime error check for `TableProvider::supports_filters_pushdown()` (was for "AND" operators does not work) HOT 10
- Support "Tracing" / Spans HOT 6
- Improvement: move rustdoc example for to_date() function to examples and provide an updated rustdoc for the function
- Further refine the Top K sort operator HOT 13
- Support multi column sorting with lists HOT 1
- Move date_part, date_trunc, date_bin functions to datafusion-functions HOT 1
- Support LargeList for ListIndex
- Support Serde for ScalarUDF in Physical Expressions HOT 1
- support for reading data from stdin for `datafusion-cli` HOT 5
- incorrect re-export for datafusion-functions-array
- Update contributor guide with updated scalar function howto HOT 1
- Casting to ARRAY types failed HOT 1
- Format plan with line number. HOT 8
- Add example for `CREATE FUNCTION` & `FunctionFactory`
- Intermittent limit.slt failure HOT 4
- DataFusion weekly project plan (Andrew Lamb) - March 4, 2024 HOT 3
- Add support for ignore nulls for LEAD, LAG in WindowAggExec. HOT 2
- TreeNode Expr Implementation for LogicalPlan's HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arrow-datafusion.