Comments (3)
is it possible to convert PhysicalExpr back to Expr?
I think it is possible, but in this case, we can just pass the Expr: Vec<Expr>
to AggregateFunctionExpr
like SortExpr
is
from arrow-datafusion.
take
from arrow-datafusion.
Hi @jayzhan211,
Continuing from our previous discussion in #10838 (comment), I believe there are still some issues.
We create AccumulatorArgs
in
https://github.com/apache/datafusion/blob/main/datafusion/physical-expr-common/src/aggregate/mod.rs#L287.
However, AggregateFunctionExpr
only takes args
that are PhysicalExpr
. I think AccumulatorArgs
is a logical plan struct that should be placed in datafusion-expr
. It can't access PhysicalExpr
.
Curiously, is it possible to convert PhysicalExpr
back to Expr
?
If not, I plan to pass the original Expr
to AggregateFunctionExpr
(just like sort_exprs: Vec<Expr>
), then pass it to AccumulatorArgs
.
Does this make sense? What do you think?
Thanks
from arrow-datafusion.
Related Issues (20)
- Update `REPLACE` scalar function to support Utf8View HOT 1
- Update `REPEAT` scalar function to support Utf8View HOT 1
- Update `REVERSE` scalar function to support Utf8View HOT 1
- Update `RTRIM` scalar function to support Utf8View HOT 2
- Update `RIGHT` scalar function to support Utf8View HOT 1
- Update `RPAD` scalar function to support Utf8View HOT 3
- Internal error `generate_series`: Internal error: could not cast value to .....arrow_array::types::Date32Type`
- Support creating arrays with non-nullable elements in `make_array` HOT 7
- Manage group values and states by blocks in aggregation HOT 7
- Support `element_at` for `Map` type HOT 1
- Change default value of `datafusion.catalog.has_header` to `true` HOT 2
- Add additional regexp functions
- Update `SPLIT_PART` scalar function to support Utf8View HOT 1
- Update `STRPOS` scalar function to support Utf8View HOT 1
- Update `SUBSTR` scalar function to support Utf8View HOT 1
- Update `TRANSLATE` scalar function to support Utf8View HOT 1
- Update `FIND_IN_SET` scalar function to support Utf8View HOT 1
- Latest nightly clippy complains about more things
- Suggest get_expr_planners() return Vec<> rather than &[] HOT 1
- Link is outdated
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arrow-datafusion.