Git Product home page Git Product logo

Comments (11)

samuelcolvin avatar samuelcolvin commented on August 26, 2024 1

For anyone else looking for this, the solution is to implement supports_filters_pushdown on the table, then use that to apply filters within scan.

Feel free to close this if you like.

from arrow-datafusion.

alamb avatar alamb commented on August 26, 2024 1

Relabed from bug to feature -- thanks @samuelcolvin

from arrow-datafusion.

alamb avatar alamb commented on August 26, 2024

I think using the reported statistics to prune using datafusion::physical_optimizer::pruning::PruningPredicate would be a nice improvement (so each table provider didn't have to apply the basic min/max filters themselves)

from arrow-datafusion.

samuelcolvin avatar samuelcolvin commented on August 26, 2024

@alamb using PruningPredicate makes sense, but please can you point me at where I need to make changes to add this functionality?

from arrow-datafusion.

alamb avatar alamb commented on August 26, 2024

@alamb using PruningPredicate makes sense, but please can you point me at where I need to make changes to add this functionality?

I recommend updating the existing though poorly named AggregateStatistics pass

And there you could potentially call ExecutionPlan::statistics() and use PruningPredicate to prove that some predicates can't be true and replace them with PlaceholderRowExec

from arrow-datafusion.

alamb avatar alamb commented on August 26, 2024

(Thank you for working on this, bTW)

from arrow-datafusion.

edmondop avatar edmondop commented on August 26, 2024

@samuelcolvin have you already started to write code?

from arrow-datafusion.

samuelcolvin avatar samuelcolvin commented on August 26, 2024

No code yet, if you'd like to work on this, feel free.

from arrow-datafusion.

samuelcolvin avatar samuelcolvin commented on August 26, 2024

Actually I'm on a flight today, so might have some time to work on this.

from arrow-datafusion.

samuelcolvin avatar samuelcolvin commented on August 26, 2024

Progress update, I've got min & max stats pruning "working" in our code, however I immediately ran into #10536, I'll let you know how I get on.

from arrow-datafusion.

alamb avatar alamb commented on August 26, 2024

You know it occurs to me that @dmitrybugakov / @jayzhan211 may be working on a similar feature with a different approach on #10456 🤔 I

from arrow-datafusion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.