Git Product home page Git Product logo

Comments (4)

theweakgod avatar theweakgod commented on May 27, 2024

OK, I have reproduced the problem and I will propose a fix later.

from apisix.

starsz avatar starsz commented on May 27, 2024

Good capture! 👍

from apisix.

theweakgod avatar theweakgod commented on May 27, 2024

@monkeyDluffy6017
Firstly, I find it odd that if a user sets allow_origins_by_metadata, then each router with allow_origins_by_metadata but without setting allow_origins would pass through all origins. Users typically use allow_origins_by_metadata to avoid configuring allow_origins for each router, yet they still need to set allow_origins for each router.

Secondly, it's also peculiar that the router registered by the user with allow_origins_by_metadata would only take effect after setting allow_origins for the router.

My understanding of allow_origins_by_metadata is that it's a publicly available list used to restrict origins.

from apisix.

monkeyDluffy6017 avatar monkeyDluffy6017 commented on May 27, 2024

OK, i got you

from apisix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.