Git Product home page Git Product logo

Comments (3)

bgoldman-videoamp avatar bgoldman-videoamp commented on May 29, 2024

So a closer look shows that the version issue is a rather superficial one (see opensearch-project/opensearch-go#73 for a similar issue. All you need to do is set the tag 2.5.0 to v2.5.0.) The real issue at hand is that the subpackage github.com/apache/airflow-client-go/airflow installed is out of date. When go get github.com/apache/airflow-client-go@latest is run, the package version for the subpackage installed is v0.0.0-20200725194829-781c285536c1 when it should be v0.0.0-20230203175943-7af9875e7d4c

from airflow-client-go.

pierrejeambrun avatar pierrejeambrun commented on May 29, 2024

Hello @bgoldman-videoamp,

Thank you for reporting this. We are currently working on the release process of this package and your feedback is really welcome.

Out of sync submodule

I think the intent of this top level module was to have a way to actually test the client, using client_test.go. As you can see in the go.mod it also depends on testify test library, so this will also add this unnecessary dependency to your project. There is no reason for airflow client to require this extra test dependency for production. (or add test code etc.)

You can install directly the submodule:

go get github.com/apache/airflow-client-go/airflow/@latest

In this testing context, it explains why the top level dependency was almost never updated, the replace directive was enough for it to work as expected.

Nonetheless it is really easy to update it, here is a PR for that, also adding install instructions #42

II Tags Convention

We followed the same tagging strategy that we use for airflow core and other api clients. Indeed, for Go It looks like tag needs to start with v... to be recognized as version for most tools. For now you can still use the hash commit to install a specific tag if needed (go get github.com/apache/airflow-client-go/airflow/@<hashcommit>), but we might want to change the way we tag release for Go client.

I will open a separate PR to suggest this change.

Thanks

from airflow-client-go.

Rick-xuy avatar Rick-xuy commented on May 29, 2024

I ran into a similar issue here. It seems that airflow is a separate module under repo github.com/apache/airflow-client-go. As far as I know, tags for submodule airflow should be like airflow/v2.5.0 to enable downstream to correctly get v2.5.0 of submodule github.com/apache/airflow-client-go/airflow.

from airflow-client-go.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.