Git Product home page Git Product logo

Comments (8)

anymaniax avatar anymaniax commented on May 13, 2024

Added with the 6.0.0. You can try it now with orval@next

from orval.

anymaniax avatar anymaniax commented on May 13, 2024

I close the issue leave me a comment if you have any problem

from orval.

OliverDudgeon avatar OliverDudgeon commented on May 13, 2024

Should the JSDoc comments be on just the generated schemas or the generated functions too? Currently, I only get comments on the schemas using orval 6.1.1.

from orval.

anymaniax avatar anymaniax commented on May 13, 2024

True will look to add it too

from orval.

OliverDudgeon avatar OliverDudgeon commented on May 13, 2024

This is mostly working for me now but I'm getting one issue. The descriptions in my OpenAPI use markdown for some formatting (which is generally supported in JS/TSDoc). This causes an issue when character combinations turn out to also be a closing comment **/.

E.g.

/**
 * Uploads a dataset.

Dataset file-naming is strictly limited to a fixed set of extensions based on the Dataset **Type**. 
You can obtain the supported types (and their extensions) via the **/type** endpoint. 
Filenames that do not comply with the supported filename extensions will be rejected.

...

It sounds like some sanitation is needed for the JSDoc just to parse out these. I think a way to do this would be a regex that looks for **/ in the string and replaces it with **\/. This appears to be at least ok in

as the added backslash is not displayed in either the generated doc.

from orval.

anymaniax avatar anymaniax commented on May 13, 2024

Hello @OliverDudgeon, thanks for reporting the bug. Do you try to fix it by yourself or do want me to do it?

from orval.

OliverDudgeon avatar OliverDudgeon commented on May 13, 2024

I've had a go

from orval.

anymaniax avatar anymaniax commented on May 13, 2024

Fixed with 6.2.1. thanks 🎉

from orval.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.