Comments (8)
Added with the 6.0.0
. You can try it now with orval@next
from orval.
I close the issue leave me a comment if you have any problem
from orval.
Should the JSDoc comments be on just the generated schemas or the generated functions too? Currently, I only get comments on the schemas using orval 6.1.1.
from orval.
True will look to add it too
from orval.
This is mostly working for me now but I'm getting one issue. The descriptions in my OpenAPI use markdown for some formatting (which is generally supported in JS/TSDoc). This causes an issue when character combinations turn out to also be a closing comment **/
.
E.g.
/**
* Uploads a dataset.
Dataset file-naming is strictly limited to a fixed set of extensions based on the Dataset **Type**.
You can obtain the supported types (and their extensions) via the **/type** endpoint.
Filenames that do not comply with the supported filename extensions will be rejected.
...
It sounds like some sanitation is needed for the JSDoc just to parse out these. I think a way to do this would be a regex that looks for **/
in the string and replaces it with **\/
. This appears to be at least ok in
- VSCode
- The TSDoc playground
as the added backslash is not displayed in either the generated doc.
from orval.
Hello @OliverDudgeon, thanks for reporting the bug. Do you try to fix it by yourself or do want me to do it?
from orval.
I've had a go
from orval.
Fixed with 6.2.1
. thanks 🎉
from orval.
Related Issues (20)
- Undefined typing of parameters in generated function
- Add support to use Biome in addition to Prettier HOT 12
- Zod: Components override not working HOT 1
- [Hono] Generated handler cannot be implemeted (`Argument of type 'string' is not assignable to parameter of type 'never'`) HOT 8
- [Hono] repsonse validator generated when there is no response HOT 1
- Zod: Support for OpenApi spec 3.1.0 HOT 2
- SWR client how to get response headers
- Discriminators are not taken into consideration when inlined in response HOT 3
- React Query: Support passing `query.meta` / `mutation.meta` options to axios instance HOT 1
- Feature request: Split polymorphic mocks into it's own functions
- Build setting allParamsOptional is not working as expected HOT 3
- swr: Mutation fetchers are not strongly typed
- OpenAPI: Support for `const` values in string parameter types HOT 4
- Zod: add to @orval/zod support of anyOf/allOf/oneOf in requestBody
- MSW: overrideResponse can be a function HOT 2
- Feature Request: create factory method for instantiating OpenAPI models HOT 2
- ERR_UNSUPPORTED_ESM_URL_SCHEME when using transformer on Windows HOT 3
- faker override to much for nested object HOT 1
- Query options for an operation have no effect
- RangeError when generating mocks HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from orval.